Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: extensions/renderer/resources/media_router_bindings.js

Issue 2014903002: [Media Router] Consistently refer to issue's learn more help page by ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 var mediaRouter; 5 var mediaRouter;
6 6
7 define('media_router_bindings', [ 7 define('media_router_bindings', [
8 'mojo/public/js/bindings', 8 'mojo/public/js/bindings',
9 'mojo/public/js/core', 9 'mojo/public/js/core',
10 'content/public/renderer/frame_service_registry', 10 'content/public/renderer/frame_service_registry',
(...skipping 335 matching lines...) Expand 10 before | Expand all | Expand 10 after
346 var secondaryActions = (issue.secondaryActions || []).map(function(e) { 346 var secondaryActions = (issue.secondaryActions || []).map(function(e) {
347 return issueActionToMojo_(e); 347 return issueActionToMojo_(e);
348 }); 348 });
349 this.service_.onIssue(new mediaRouterMojom.Issue({ 349 this.service_.onIssue(new mediaRouterMojom.Issue({
350 'route_id': issue.routeId, 350 'route_id': issue.routeId,
351 'severity': issueSeverityToMojo_(issue.severity), 351 'severity': issueSeverityToMojo_(issue.severity),
352 'title': issue.title, 352 'title': issue.title,
353 'message': issue.message, 353 'message': issue.message,
354 'default_action': issueActionToMojo_(issue.defaultAction), 354 'default_action': issueActionToMojo_(issue.defaultAction),
355 'secondary_actions': secondaryActions, 355 'secondary_actions': secondaryActions,
356 'help_url': issue.helpUrl, 356 'help_page_id': issue.helpPageId,
357 'is_blocking': issue.isBlocking 357 'is_blocking': issue.isBlocking
358 })); 358 }));
359 }; 359 };
360 360
361 /** 361 /**
362 * Called by the provider manager when the set of active routes 362 * Called by the provider manager when the set of active routes
363 * has been updated. 363 * has been updated.
364 * @param {!Array<MediaRoute>} routes The active set of media routes. 364 * @param {!Array<MediaRoute>} routes The active set of media routes.
365 * @param {string=} opt_sourceUrn The sourceUrn associated with this route 365 * @param {string=} opt_sourceUrn The sourceUrn associated with this route
366 * query. This parameter is optional and can be empty. 366 * query. This parameter is optional and can be empty.
(...skipping 447 matching lines...) Expand 10 before | Expand all | Expand 10 after
814 }; 814 };
815 815
816 mediaRouter = new MediaRouter(connector.bindHandleToProxy( 816 mediaRouter = new MediaRouter(connector.bindHandleToProxy(
817 serviceProvider.connectToService( 817 serviceProvider.connectToService(
818 mediaRouterMojom.MediaRouter.name), 818 mediaRouterMojom.MediaRouter.name),
819 mediaRouterMojom.MediaRouter)); 819 mediaRouterMojom.MediaRouter));
820 820
821 return mediaRouter; 821 return mediaRouter;
822 }); 822 });
823 823
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698