Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2014893002: Fix a flaky failure in socket_bind_test. (Closed)

Created:
4 years, 6 months ago by Florian Schneider
Modified:
4 years, 6 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a flaky failure in socket_bind_test. Make the test more robust against the case where it use a IPv4 socket address is already in use with IPv6 or vice versa by first finding a port that is free for both. BUG= R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/b1ce8afde50d723a5f359ce26019e1df510cc7d5

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -16 lines) Patch
M tests/standalone/io/socket_bind_test.dart View 3 chunks +24 lines, -16 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
Florian Schneider
4 years, 6 months ago (2016-05-26 16:49:33 UTC) #2
kustermann
LGTM https://codereview.chromium.org/2014893002/diff/1/tests/standalone/io/socket_bind_test.dart File tests/standalone/io/socket_bind_test.dart (right): https://codereview.chromium.org/2014893002/diff/1/tests/standalone/io/socket_bind_test.dart#newcode116 tests/standalone/io/socket_bind_test.dart:116: var socket = await ServerSocket.bind(InternetAddress.ANY_IP_V6, 0, v6Only: false); ...
4 years, 6 months ago (2016-05-26 16:56:27 UTC) #3
Florian Schneider
Committed patchset #1 (id:1) manually as b1ce8afde50d723a5f359ce26019e1df510cc7d5 (presubmit successful).
4 years, 6 months ago (2016-05-26 17:38:40 UTC) #5
Florian Schneider
4 years, 6 months ago (2016-05-26 17:39:51 UTC) #6
Message was sent while issue was closed.
On 2016/05/26 16:56:27, kustermann wrote:
> LGTM
> 
>
https://codereview.chromium.org/2014893002/diff/1/tests/standalone/io/socket_...
> File tests/standalone/io/socket_bind_test.dart (right):
> 
>
https://codereview.chromium.org/2014893002/diff/1/tests/standalone/io/socket_...
> tests/standalone/io/socket_bind_test.dart:116: var socket = await
> ServerSocket.bind(InternetAddress.ANY_IP_V6, 0, v6Only: false);
> long line

Will fix in a separate CL.

Powered by Google App Engine
This is Rietveld 408576698