xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp - Issue 2014863002: Revert of Remove parameters which are always null

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp

Issue 2014863002: Revert of Remove parameters which are always null (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp

diff --git a/xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp b/xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp

index a3b686bb56e8a85300648e2a0a64f0529c291e57..94fa8db96c0b6c320ea88e6c01b7295ec631fe9f 100644

--- a/xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp

+++ b/xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp

@@ -310,7 +310,7 @@

if (iLength >= 1) {

FXJSE_HVALUE hValue = pArguments->GetValue(0);

if (FXJSE_Value_IsObject(hValue)) {

- pNode = static_cast<CXFA_Node*>(FXJSE_Value_ToObject(hValue));

+ pNode = static_cast<CXFA_Node*>(FXJSE_Value_ToObject(hValue, nullptr));

} else if (FXJSE_Value_IsUTF8String(hValue)) {

CFX_ByteString bsString;

FXJSE_Value_ToUTF8String(hValue, bsString);

@@ -511,7 +511,7 @@