Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2014863002: Revert of Remove parameters which are always null (Closed)

Created:
4 years, 7 months ago by dsinclair
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert of Remove parameters which are always null (patchset #1 id:1 of https://codereview.chromium.org/2009413002/ ) Reason for revert: Suspect that the lack of this parameter being passed accurately to GetObject is leading to https://bugs.chromium.org/p/chromium/issues/detail?id=613607, and that the right fix will be to pass it. Original issue's description: > Remove parameters which are always null > > These parameters are never set, remove them and their supporting code. > > Committed: https://pdfium.googlesource.com/pdfium/+/818e1900a3811e1bde1e594e4966db612f845966 TBR=tsepez@chromium.org,thestig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://pdfium.googlesource.com/pdfium/+/dd6a46c7eddc31d29b2d2630378c52c25363ce59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -138 lines) Patch
M xfa/fxfa/app/xfa_ffdochandler.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 111 chunks +181 lines, -115 lines 0 comments Download
M xfa/fxfa/parser/xfa_script.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.cpp View 9 chunks +14 lines, -9 lines 0 comments Download
M xfa/fxjse/cfxjse_arguments.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxjse/class.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M xfa/fxjse/include/fxjse.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxjse/util_inline.h View 2 chunks +10 lines, -1 line 0 comments Download
M xfa/fxjse/value.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxjse/value.cpp View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dsinclair
Created Revert of Remove parameters which are always null
4 years, 7 months ago (2016-05-26 15:41:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014863002/1
4 years, 7 months ago (2016-05-26 15:41:38 UTC) #2
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 15:41:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/dd6a46c7eddc31d29b2d2630378c52c25363...

Powered by Google App Engine
This is Rietveld 408576698