Show dialogs for syncing to managed accounts.

Show dialogs for syncing to managed accounts earlier in the signin flow, moving them forward to be alongside the dialog for importing/wiping sync data.

BUG=595411, 612165
Committed: https://crrev.com/03f33b2926c08eccec355081049e78b00e80e4ee
Cr-Commit-Position: refs/heads/master@{#403195}

[PEConn, 2016-05-26 14:10:24]

peconn@chromium.org changed reviewers:
+ bauerb@chromium.org

[PEConn, 2016-05-26 14:10:25]

Please take a look, this is a work in progress. I still have to:

- Add 'sign out of managed account' dialog when signing out.
- Figure out if the accounts are managed.

[PEConn, 2016-05-27 16:00:53]

I've done more work on this - we now determine whether the account is managed or
not properly.

Still to do:
- Move the 'is the new account managed' check forward, this requires promises
though...
- Add a dialog on sign out

[maxbogue, 2016-05-27 16:37:45]

maxbogue@chromium.org changed reviewers:
+ maxbogue@chromium.org

[maxbogue, 2016-05-27 16:37:46]

Two things from a quick glance at this:

- Everything added to .../sync/ui/ in this are more part of the signin flow than
directly sync related, as well as ConfirmImportSyncDataDialog. It only matters
because of sync, but profiles have data independent of sync. I would like them
to live in signin directories, please.
- If you need a Promise-like thing I made a SimpleFuture class somewhere for
tests, though.. I have no idea why you'd need it in normal code. Blocking a
thread on a result is generally not what you want outside tests.

[PEConn, 2016-05-27 16:58:34]

On 2016/05/27 16:37:46, maxbogue wrote:
> Two things from a quick glance at this:
> 
> - Everything added to .../sync/ui/ in this are more part of the signin flow
than
> directly sync related, as well as ConfirmImportSyncDataDialog. It only matters
> because of sync, but profiles have data independent of sync. I would like them
> to live in signin directories, please.

That is fine, I'll move them.

> - If you need a Promise-like thing I made a SimpleFuture class somewhere for
> tests, though.. I have no idea why you'd need it in normal code. Blocking a
> thread on a result is generally not what you want outside tests.

I'm currently working on a Promise class (I'd started it a while ago) in
https://codereview.chromium.org/1885463002/.

In the StateMachine there is a check to see if the newAccountName has a
management domain (taking a callback), this currently takes about 3 seconds
which is a bit jarring for the user (since the previous dialog disappears). The
idea would be to replace:

boolean mNewAccountManaged

with

Promise<Boolean> mNewAccountManaged

Then I could kick off the asynchronous check for a management domain as soon as
the StateMachine is created, allowing it to load the domain information in the
background while the user is reading through the first dialog. When the check
completes, it fulfils the Promise.

Using Promises gives us a nice way to encapsulate the 'returned true, returned
false, waiting on a value', and if when we need the value before it is ready, we
can just put 'progress()' into a 'then' on the Promise.

[maxbogue, 2016-05-27 17:39:11]

> I'm currently working on a Promise class (I'd started it a while ago) in
> https://codereview.chromium.org/1885463002/.
> 
> In the StateMachine there is a check to see if the newAccountName has a
> management domain (taking a callback), this currently takes about 3 seconds
> which is a bit jarring for the user (since the previous dialog disappears).
The
> idea would be to replace:
> 
> boolean mNewAccountManaged
> 
> with
> 
> Promise<Boolean> mNewAccountManaged
> 
> Then I could kick off the asynchronous check for a management domain as soon
as
> the StateMachine is created, allowing it to load the domain information in the
> background while the user is reading through the first dialog. When the check
> completes, it fulfils the Promise.
> 
> Using Promises gives us a nice way to encapsulate the 'returned true, returned
> false, waiting on a value', and if when we need the value before it is ready,
we
> can just put 'progress()' into a 'then' on the Promise.

Ah it was another CL of yours where I mentioned SimpleFuture some other time,
wasn't it? I couldn't remember. Cool, I understand now how Promise would be
used; sounds awesome :)

[PEConn, 2016-06-02 09:42:17]

The CQ bit was checked by peconn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-02 09:42:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014833002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014833002/40001

[commit-bot: I haz the power, 2016-06-02 12:03:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 12:03:58]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Bernhard Bauer, 2016-06-03 08:50:07]

https://codereview.chromium.org/2014833002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmManagedSyncDataDialog.java
(right):

https://codereview.chromium.org/2014833002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmManagedSyncDataDialog.java:116:

Nit: no empty line at the beginning of a block.

https://codereview.chromium.org/2014833002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmSyncDataStateMachine.java
(right):

https://codereview.chromium.org/2014833002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmSyncDataStateMachine.java:95:
// Assumes that the email is of the form user@domain.com, and returns Domain.
This should use (the native) gaia::ExtractDomainName() instead of trying to
replicate its behavior.

https://codereview.chromium.org/2014833002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmSyncDataStateMachine.java:97:
int end = email.lastIndexOf('.');
This is also a bit weird. For user@example.co.uk, wouldn't this return
"Example.co"? Looking at the spec for the strings, it says e.g. "You are signing
in with an account managed by <domain name>", and the domain name would be the
full portion after the "@" sign.

https://codereview.chromium.org/2014833002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmSyncDataStateMachine.java:103:
* itself directly or creating a dialog. If the dialog is dismissed or answered
negatively, the
Nit: remove the command after "negatively" (or add one after "positively").

https://codereview.chromium.org/2014833002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmSyncDataStateMachine.java:139:
if (SigninManager.couldUserBeManaged(mNewAccountName)) {
You could also move this into fetchManagementDomain(). A caller needs to call
that one anyway if this returns true, so you might as well do this check for
them.

https://codereview.chromium.org/2014833002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmSyncDataStateMachine.java:140:

Remove the empty line.

https://codereview.chromium.org/2014833002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmSyncDataStateMachine.java:172:
default:
Could you just list the remaining value here?

https://codereview.chromium.org/2014833002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmSyncDataStateMachine.java:193:
mCallback.onCancel();
You could also transition to the DONE state here, just to clean things up.

https://codereview.chromium.org/2014833002/diff/40001/chrome/browser/android/...
File chrome/browser/android/signin/signin_manager_android.cc (right):

https://codereview.chromium.org/2014833002/diff/40001/chrome/browser/android/...
chrome/browser/android/signin/signin_manager_android.cc:309: namespace {
Move to this the existing anonymous namespace at the top?

https://codereview.chromium.org/2014833002/diff/40001/chrome/browser/android/...
chrome/browser/android/signin/signin_manager_android.cc:319:
base::android::RunCallbackAndroid(callback, j_domain);
As discussed offline, this should be a boolean |is_managed| or something.

https://codereview.chromium.org/2014833002/diff/40001/chrome/browser/android/...
chrome/browser/android/signin/signin_manager_android.cc:336:
service->RegisterForPolicy(
You are sure that registering for policy without unregistering afterwards is not
a problem?

[PEConn, 2016-06-27 09:34:31]

peconn@chromium.org changed reviewers:
+ torne@chromium.org

[PEConn, 2016-06-27 09:34:33]

@torne: Could you please look at my change to Promise.java.

https://codereview.chromium.org/2014833002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmManagedSyncDataDialog.java
(right):

https://codereview.chromium.org/2014833002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmManagedSyncDataDialog.java:116:

On 2016/06/03 08:50:06, Bernhard Bauer wrote:
> Nit: no empty line at the beginning of a block.

Done.

https://codereview.chromium.org/2014833002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmSyncDataStateMachine.java
(right):

https://codereview.chromium.org/2014833002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmSyncDataStateMachine.java:95:
// Assumes that the email is of the form user@domain.com, and returns Domain.
On 2016/06/03 08:50:06, Bernhard Bauer wrote:
> This should use (the native) gaia::ExtractDomainName() instead of trying to
> replicate its behavior.

Done.

https://codereview.chromium.org/2014833002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmSyncDataStateMachine.java:97:
int end = email.lastIndexOf('.');
On 2016/06/03 08:50:06, Bernhard Bauer wrote:
> This is also a bit weird. For mailto:user@example.co.uk, wouldn't this return
> "Example.co"? Looking at the spec for the strings, it says e.g. "You are
signing
> in with an account managed by <domain name>", and the domain name would be the
> full portion after the "@" sign.

Why did you think 'Example.co' - it returns 'Example'? Did you think lastIndexOf
did some fancy regex/wildcard matching?

I had removed the TLD because I though it looked neater for the dialog to say:
'... managed by Google...'
instead of
'... managed by google.com'

https://codereview.chromium.org/2014833002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmSyncDataStateMachine.java:103:
* itself directly or creating a dialog. If the dialog is dismissed or answered
negatively, the
On 2016/06/03 08:50:06, Bernhard Bauer wrote:
> Nit: remove the command after "negatively" (or add one after "positively").

Done.

https://codereview.chromium.org/2014833002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmSyncDataStateMachine.java:139:
if (SigninManager.couldUserBeManaged(mNewAccountName)) {
On 2016/06/03 08:50:06, Bernhard Bauer wrote:
> You could also move this into fetchManagementDomain(). A caller needs to call
> that one anyway if this returns true, so you might as well do this check for
> them.

Done.

https://codereview.chromium.org/2014833002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmSyncDataStateMachine.java:140:

On 2016/06/03 08:50:06, Bernhard Bauer wrote:
> Remove the empty line.

Done.

https://codereview.chromium.org/2014833002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmSyncDataStateMachine.java:172:
default:
On 2016/06/03 08:50:06, Bernhard Bauer wrote:
> Could you just list the remaining value here?

Done.

https://codereview.chromium.org/2014833002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmSyncDataStateMachine.java:193:
mCallback.onCancel();
On 2016/06/03 08:50:06, Bernhard Bauer wrote:
> You could also transition to the DONE state here, just to clean things up.

Done.

https://codereview.chromium.org/2014833002/diff/40001/chrome/browser/android/...
File chrome/browser/android/signin/signin_manager_android.cc (right):

https://codereview.chromium.org/2014833002/diff/40001/chrome/browser/android/...
chrome/browser/android/signin/signin_manager_android.cc:309: namespace {
On 2016/06/03 08:50:06, Bernhard Bauer wrote:
> Move to this the existing anonymous namespace at the top?

Done.

https://codereview.chromium.org/2014833002/diff/40001/chrome/browser/android/...
chrome/browser/android/signin/signin_manager_android.cc:319:
base::android::RunCallbackAndroid(callback, j_domain);
On 2016/06/03 08:50:07, Bernhard Bauer wrote:
> As discussed offline, this should be a boolean |is_managed| or something.

Done.

[Torne, 2016-06-27 10:10:34]

lgtm

[Bernhard Bauer, 2016-06-29 10:51:27]

https://codereview.chromium.org/2014833002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmSyncDataStateMachine.java
(right):

https://codereview.chromium.org/2014833002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/sync/ui/ConfirmSyncDataStateMachine.java:97:
int end = email.lastIndexOf('.');
On 2016/06/27 09:34:33, PEConn1 wrote:
> On 2016/06/03 08:50:06, Bernhard Bauer wrote:
> > This is also a bit weird. For mailto:user@example.co.uk, wouldn't this
return
> > "Example.co"? Looking at the spec for the strings, it says e.g. "You are
> signing
> > in with an account managed by <domain name>", and the domain name would be
the
> > full portion after the "@" sign.
> 
> Why did you think 'Example.co' - it returns 'Example'? Did you think
lastIndexOf
> did some fancy regex/wildcard matching?

But it's _last_ index of, and the last index in `user@example.co.uk` is the
second period, so from start to end would be `example.co`.

> I had removed the TLD because I though it looked neater for the dialog to say:
> '... managed by Google...'
> instead of
> '... managed by google.com'

Generally speaking, getting a single readable string out of a hostname is
surprisingly difficult. You have to strip a number of components at the end, but
it depends on the TLD -- i.e. for foo.bar.co.uk you want to strip .co.uk, but
for foo.bar.com you only want to strip .com. This is why just using
gaia::ExtractDomainName() gives me way fewer headaches :)

https://codereview.chromium.org/2014833002/diff/40001/chrome/browser/android/...
File chrome/browser/android/signin/signin_manager_android.cc (right):

https://codereview.chromium.org/2014833002/diff/40001/chrome/browser/android/...
chrome/browser/android/signin/signin_manager_android.cc:336:
service->RegisterForPolicy(
On 2016/06/03 08:50:07, Bernhard Bauer wrote:
> You are sure that registering for policy without unregistering afterwards is
not
> a problem?

^^^

https://codereview.chromium.org/2014833002/diff/60001/base/android/java/src/o...
File base/android/java/src/org/chromium/base/Promise.java (right):

https://codereview.chromium.org/2014833002/diff/60001/base/android/java/src/o...
base/android/java/src/org/chromium/base/Promise.java:132: public Callback<T>
fulfillOnCallback() {
Nit: I kind of want to call this fulfillmentCallback(), because it returns a
callback (fulfillOnCallback() sounds like it would _accept_ a callback that
would fulfill it).

https://codereview.chromium.org/2014833002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java
(right):

https://codereview.chromium.org/2014833002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java:55:
public @interface State {}
Can this interface be private?

https://codereview.chromium.org/2014833002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java
(right):

https://codereview.chromium.org/2014833002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java:654:
new Handler(Looper.myLooper()).post(new Runnable() {
Use ThreadUtils.postOnUiThread()?

https://codereview.chromium.org/2014833002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java:657:
callback.onResult(Boolean.FALSE);
Nit: I personally would pass in a `true` literal and have the Java compiler do
the boxing.

[PEConn, 2016-06-29 17:52:39]

Fixed nits, I am aware I still need to verify that registering without
unregistering is fine.

https://codereview.chromium.org/2014833002/diff/60001/base/android/java/src/o...
File base/android/java/src/org/chromium/base/Promise.java (right):

https://codereview.chromium.org/2014833002/diff/60001/base/android/java/src/o...
base/android/java/src/org/chromium/base/Promise.java:132: public Callback<T>
fulfillOnCallback() {
On 2016/06/29 10:51:26, Bernhard Bauer wrote:
> Nit: I kind of want to call this fulfillmentCallback(), because it returns a
> callback (fulfillOnCallback() sounds like it would _accept_ a callback that
> would fulfill it).

Done.

https://codereview.chromium.org/2014833002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java
(right):

https://codereview.chromium.org/2014833002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/signin/ConfirmSyncDataStateMachine.java:55:
public @interface State {}
On 2016/06/29 10:51:26, Bernhard Bauer wrote:
> Can this interface be private?

Done.

https://codereview.chromium.org/2014833002/diff/60001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java
(right):

https://codereview.chromium.org/2014833002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java:654:
new Handler(Looper.myLooper()).post(new Runnable() {
On 2016/06/29 10:51:26, Bernhard Bauer wrote:
> Use ThreadUtils.postOnUiThread()?

Done.

https://codereview.chromium.org/2014833002/diff/60001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java:657:
callback.onResult(Boolean.FALSE);
On 2016/06/29 10:51:26, Bernhard Bauer wrote:
> Nit: I personally would pass in a `true` literal and have the Java compiler do
> the boxing.

Done.

[PEConn, 2016-06-29 17:52:53]

The CQ bit was checked by peconn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 17:55:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 19:31:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 19:31:14]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[PEConn, 2016-06-30 08:15:36]

Description was changed from

==========
Show dialogs for syncing to managed accounts.

BUG=595411
==========

to

==========
Show dialogs for syncing to managed accounts earlier in the signin flow, moving
them forward to be alongside the dialog for importing/wiping sync data.

BUG=595411, 612165
==========

[Bernhard Bauer, 2016-06-30 08:40:55]

On 2016/06/29 17:52:39, PEConn1 wrote:
> Fixed nits, I am aware I still need to verify that registering without
> unregistering is fine.

Thanks! LGTM once that is resolved.

[PEConn, 2016-06-30 09:26:44]

https://codereview.chromium.org/2014833002/diff/40001/chrome/browser/android/...
File chrome/browser/android/signin/signin_manager_android.cc (right):

https://codereview.chromium.org/2014833002/diff/40001/chrome/browser/android/...
chrome/browser/android/signin/signin_manager_android.cc:336:
service->RegisterForPolicy(
On 2016/06/29 10:51:26, Bernhard Bauer wrote:
> On 2016/06/03 08:50:07, Bernhard Bauer wrote:
> > You are sure that registering for policy without unregistering afterwards is
> not
> > a problem?
> 
> ^^^

In RegisterForPolicy, the CloudPolicyClient (which appears to be the only thing
that has state modified in StartRegistrationWithLoginToken) is a local variable,
so I don't think we have any side effects.

[PEConn, 2016-06-30 09:36:07]

The CQ bit was checked by peconn@chromium.org

[PEConn, 2016-06-30 09:36:07]

The patchset sent to the CQ was uploaded after l-g-t-m from torne@chromium.org
Link to the patchset: https://codereview.chromium.org/2014833002/#ps80001
(title: "Nits.")

[commit-bot: I haz the power, 2016-06-30 09:36:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 11:04:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 11:04:42]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[PEConn, 2016-06-30 14:21:40]

The CQ bit was checked by peconn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-30 14:22:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 15:04:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 15:04:20]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[PEConn, 2016-06-30 15:25:45]

The CQ bit was checked by peconn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-30 15:25:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 16:21:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 16:21:51]

Dry run: This issue passed the CQ dry run.

[PEConn, 2016-06-30 16:28:55]

The CQ bit was checked by peconn@chromium.org

[PEConn, 2016-06-30 16:28:56]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
torne@chromium.org
Link to the patchset: https://codereview.chromium.org/2014833002/#ps120001
(title: "Replace getContext with getActivity in AccountManagementFragment.")

[commit-bot: I haz the power, 2016-06-30 16:29:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 16:33:48]

Description was changed from

==========
Show dialogs for syncing to managed accounts earlier in the signin flow, moving
them forward to be alongside the dialog for importing/wiping sync data.

BUG=595411, 612165
==========

to

==========
Show dialogs for syncing to managed accounts earlier in the signin flow, moving
them forward to be alongside the dialog for importing/wiping sync data.

BUG=595411, 612165
==========

[commit-bot: I haz the power, 2016-06-30 16:33:48]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-06-30 16:34:01]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 16:35:23]

Description was changed from

==========
Show dialogs for syncing to managed accounts earlier in the signin flow, moving
them forward to be alongside the dialog for importing/wiping sync data.

BUG=595411, 612165
==========

to

==========
Show dialogs for syncing to managed accounts earlier in the signin flow, moving
them forward to be alongside the dialog for importing/wiping sync data.

BUG=595411, 612165

Committed: https://crrev.com/03f33b2926c08eccec355081049e78b00e80e4ee
Cr-Commit-Position: refs/heads/master@{#403195}
==========

[commit-bot: I haz the power, 2016-06-30 16:35:24]

Patchset 7 (id:??) landed as
https://crrev.com/03f33b2926c08eccec355081049e78b00e80e4ee
Cr-Commit-Position: refs/heads/master@{#403195}