Cleanup for pkg/observe and pkg/polymer

Cleanup for pkg/observe and pkg/polymer

Remove unused imports, fixed usage of deprecated members

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=33770

[kevmoo, 2014-03-17 01:31:57]

Not sure if I versioned the packages correctly - please verify

[kevmoo, 2014-03-17 01:35:03]

https://codereview.chromium.org/201483002/diff/1/pkg/observe/pubspec.yaml
File pkg/observe/pubspec.yaml (right):

https://codereview.chromium.org/201483002/diff/1/pkg/observe/pubspec.yaml#new...
pkg/observe/pubspec.yaml:11: environment:
This is the delta that the editor does. Consistent is goodness.

https://codereview.chromium.org/201483002/diff/1/pkg/polymer/lib/polymer_elem...
File pkg/polymer/lib/polymer_element.dart (left):

https://codereview.chromium.org/201483002/diff/1/pkg/polymer/lib/polymer_elem...
pkg/polymer/lib/polymer_element.dart:7: export 'polymer.dart' show
PolymerElement, registerPolymerElement;
registerPolymerElement no longer exists

https://codereview.chromium.org/201483002/diff/1/pkg/polymer/lib/src/build/mi...
File pkg/polymer/lib/src/build/mirrors_remover.dart (right):

https://codereview.chromium.org/201483002/diff/1/pkg/polymer/lib/src/build/mi...
pkg/polymer/lib/src/build/mirrors_remover.dart:35: ..write(code.substring(end)
Clearly this code is not being run...

https://codereview.chromium.org/201483002/diff/1/pkg/polymer/test/property_ch...
File pkg/polymer/test/property_change_test.dart (left):

https://codereview.chromium.org/201483002/diff/1/pkg/polymer/test/property_ch...
pkg/polymer/test/property_change_test.dart:8: import 'dart:html';
an unused import. Required to force drt tests? Not sure. A comment would be good
if that's the case

[Siggi Cherem (dart-lang), 2014-03-17 17:45:18]

lgtm

https://codereview.chromium.org/201483002/diff/1/pkg/observe/pubspec.yaml
File pkg/observe/pubspec.yaml (right):

https://codereview.chromium.org/201483002/diff/1/pkg/observe/pubspec.yaml#new...
pkg/observe/pubspec.yaml:2: version: 0.10.0-pre.4
pre.4 => pre.3 ?

https://codereview.chromium.org/201483002/diff/1/pkg/observe/pubspec.yaml#new...
pkg/observe/pubspec.yaml:11: environment:
On 2014/03/17 01:35:03, kevmoo wrote:
> This is the delta that the editor does. Consistent is goodness.

We actually prefer it at the bottom :-). Could we file a request so that the
editor puts it at the bottom too?

https://codereview.chromium.org/201483002/diff/1/pkg/polymer/lib/src/build/mi...
File pkg/polymer/lib/src/build/mirrors_remover.dart (right):

https://codereview.chromium.org/201483002/diff/1/pkg/polymer/lib/src/build/mi...
pkg/polymer/lib/src/build/mirrors_remover.dart:35: ..write(code.substring(end)
On 2014/03/17 01:35:03, kevmoo wrote:
> Clearly this code is not being run...

yeah - I have a fix on my local client. Feel free to revert this file (it'll
avoid me some merge conflicts :-) )

https://codereview.chromium.org/201483002/diff/1/pkg/polymer/test/property_ch...
File pkg/polymer/test/property_change_test.dart (left):

https://codereview.chromium.org/201483002/diff/1/pkg/polymer/test/property_ch...
pkg/polymer/test/property_change_test.dart:8: import 'dart:html';
On 2014/03/17 01:35:03, kevmoo wrote:
> an unused import. Required to force drt tests? Not sure. A comment would be
good
> if that's the case

not sure - but easy to test it out :)

If you run test.py on all configurations and it's all good, then we can delete
it.

[Jennifer Messerly, 2014-03-17 18:06:10]

mostly looks good but not pubspec.

https://codereview.chromium.org/201483002/diff/1/pkg/observe/pubspec.yaml
File pkg/observe/pubspec.yaml (right):

https://codereview.chromium.org/201483002/diff/1/pkg/observe/pubspec.yaml#new...
pkg/observe/pubspec.yaml:2: version: 0.10.0-pre.4
On 2014/03/17 17:45:18, Siggi Cherem (dart-lang) wrote:
> pre.4 => pre.3 ?

yes should be pre.3.dev

.dev means we aren't uploading it immediately

https://codereview.chromium.org/201483002/diff/1/pkg/observe/pubspec.yaml#new...
pkg/observe/pubspec.yaml:11: environment:
On 2014/03/17 17:45:18, Siggi Cherem (dart-lang) wrote:
> On 2014/03/17 01:35:03, kevmoo wrote:
> > This is the delta that the editor does. Consistent is goodness.
> 
> We actually prefer it at the bottom :-). Could we file a request so that the
> editor puts it at the bottom too?

that could work too. fwiw this placement doesn't bother me tho :)

https://codereview.chromium.org/201483002/diff/1/pkg/polymer/test/property_ch...
File pkg/polymer/test/property_change_test.dart (left):

https://codereview.chromium.org/201483002/diff/1/pkg/polymer/test/property_ch...
pkg/polymer/test/property_change_test.dart:8: import 'dart:html';
On 2014/03/17 17:45:18, Siggi Cherem (dart-lang) wrote:
> On 2014/03/17 01:35:03, kevmoo wrote:
> > an unused import. Required to force drt tests? Not sure. A comment would be
> good
> > if that's the case
> 
> not sure - but easy to test it out :)
> 
> If you run test.py on all configurations and it's all good, then we can delete
> it.

it shouldn't be needed anymore AFAIK

[kevmoo, 2014-03-17 20:08:45]

PTAL

https://codereview.chromium.org/201483002/diff/1/pkg/observe/pubspec.yaml
File pkg/observe/pubspec.yaml (right):

https://codereview.chromium.org/201483002/diff/1/pkg/observe/pubspec.yaml#new...
pkg/observe/pubspec.yaml:2: version: 0.10.0-pre.4
On 2014/03/17 18:06:10, John Messerly wrote:
> On 2014/03/17 17:45:18, Siggi Cherem (dart-lang) wrote:
> > pre.4 => pre.3 ?
> 
> yes should be pre.3.dev
> 
> .dev means we aren't uploading it immediately

Done.

https://codereview.chromium.org/201483002/diff/1/pkg/observe/pubspec.yaml#new...
pkg/observe/pubspec.yaml:11: environment:
On 2014/03/17 18:06:10, John Messerly wrote:
> On 2014/03/17 17:45:18, Siggi Cherem (dart-lang) wrote:
> > On 2014/03/17 01:35:03, kevmoo wrote:
> > > This is the delta that the editor does. Consistent is goodness.
> > 
> > We actually prefer it at the bottom :-). Could we file a request so that the
> > editor puts it at the bottom too?
> 
> that could work too. fwiw this placement doesn't bother me tho :)

Reverted to keep things simple.

[Siggi Cherem (dart-lang), 2014-03-17 20:10:10]

lgtm, thanks Kevin!

[kevmoo, 2014-03-17 20:23:57]

Committed patchset #3 manually as r33770 (presubmit successful).