Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2014813002: Revert of bluetooth: Remove UriBeacon code (Closed)

Created:
4 years, 6 months ago by Olivier
Modified:
4 years, 6 months ago
Reviewers:
scheib, ortuno
CC:
chromium-reviews, mattreynolds, ortuno+watch_chromium.org, scheib+watch_chromium.org, Olivier
Base URL:
https://chromium.googlesource.com/chromium/src.git@my-origin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of bluetooth: Remove UriBeacon code (patchset #2 id:20001 of https://codereview.chromium.org/2015703002/ ) Reason for revert: This code is still used on iOS. The code will be upstreamed soon, but at the moment some dependencies prevent it. Original issue's description: > bluetooth: Remove UriBeacon code > > This code was introduced by the Physical Web team when they were exploring > integration with Chrome. They ended up going a different route so this > code is useless now. > > Committed: https://crrev.com/3d392de68c541604a01a0c077c44d0ba4c7a02c7 > Cr-Commit-Position: refs/heads/master@{#396112} TBR=scheib@chromium.org,ortuno@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/2faae4040325203cc26381aa24126c7fc6320f8a Cr-Commit-Position: refs/heads/master@{#396142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -0 lines) Patch
M device/bluetooth/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/bluetooth.gyp View 2 chunks +13 lines, -0 lines 0 comments Download
A device/bluetooth/uribeacon/BUILD.gn View 1 chunk +13 lines, -0 lines 0 comments Download
A device/bluetooth/uribeacon/uri_encoder.h View 1 chunk +44 lines, -0 lines 0 comments Download
A device/bluetooth/uribeacon/uri_encoder.cc View 1 chunk +132 lines, -0 lines 0 comments Download
A device/bluetooth/uribeacon/uri_encoder_unittest.cc View 1 chunk +95 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Olivier
Created Revert of bluetooth: Remove UriBeacon code
4 years, 6 months ago (2016-05-26 07:39:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014813002/1
4 years, 6 months ago (2016-05-26 07:39:09 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-26 07:39:46 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-05-26 07:40:55 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2faae4040325203cc26381aa24126c7fc6320f8a
Cr-Commit-Position: refs/heads/master@{#396142}

Powered by Google App Engine
This is Rietveld 408576698