chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java - Issue 2014803002: Move DownloadControllerAndroid from content/ to chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2014803002: Move DownloadControllerAndroid from content/ to chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ChromeDownloadDelegate.nativeInit Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java ('k') | chrome/android/java_sources.gni » ('j') | chrome/browser/android/download/chrome_download_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

index e376d28cf50b9f3c0dd08b20e903d4dd5841cc18..070769dbbecb1408e1c696ea2c94a187f6d7cf88 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

@@ -1829,6 +1829,8 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,

mContentViewCore.setContentViewClient(mContentViewClient);

}

+ mDownloadDelegate = new ChromeDownloadDelegate(mThemedApplicationContext, this);

assert mNativeTabAndroid != 0;

nativeInitWebContents(

mNativeTabAndroid, mIncognito, mContentViewCore, mWebContentsDelegate,

@@ -1858,10 +1860,6 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,

// web views.

mContentViewCore.setShouldSetAccessibilityFocusOnPageLoad(true);

- mDownloadDelegate = new ChromeDownloadDelegate(

- mThemedApplicationContext, this);

- cvc.setDownloadDelegate(mDownloadDelegate);

setInterceptNavigationDelegate(mDelegateFactory.createInterceptNavigationDelegate(

this));