[Grit] Allow preprocess-only "inlining"

[Grit] Allow preprocess-only "inlining"

Grit inlining is occasionally more than necessary - sometimes, all
that's needed is processing of <if> and <include> directives, without
following every html reference.

(One specific case: When the HTML refers to relative resources. Grit
tries to treat them as files, since no protocol is specified)

This change adds support for the "preprocess" attribute, which disables
link inlining.

R=thestig@chromium.org
BUG=none

Committed: https://crrev.com/72ed2672c529ba14ff68b3f69c2c211b058bfee4
Cr-Commit-Position: refs/heads/master@{#396119}

[groby-ooo-7-16, 2016-05-26 01:54:35]

Description was changed from

==========
[Grit] Allow preprocess-only "inlining"

Grit inlining is occasionally more than necessary - sometimes, all
that's needed is processing of <if> and <include> directives, without
following every html reference.

(One specific case: When the HTML refers to relative resources. Grit
tries to treat them as files, since no protocol is specified)

This change adds support for the "preprocess" attribute, which disables
link inlining.

R=thestig@chromium.org
BUG=none
==========

to

==========
[Grit] Allow preprocess-only "inlining"

Grit inlining is occasionally more than necessary - sometimes, all
that's needed is processing of <if> and <include> directives, without
following every html reference.

(One specific case: When the HTML refers to relative resources. Grit
tries to treat them as files, since no protocol is specified)

This change adds support for the "preprocess" attribute, which disables
link inlining.

R=thestig@chromium.org
BUG=none
==========

[groby-ooo-7-16, 2016-05-26 01:54:52]

cc'd dbeam, since md-settings relevant

[Dan Beam, 2016-05-26 02:00:46]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-05-26 02:00:47]

lgtm

https://codereview.chromium.org/2014793002/diff/1/tools/grit/grit/gather/chro...
File tools/grit/grit/gather/chrome_html.py (right):

https://codereview.chromium.org/2014793002/diff/1/tools/grit/grit/gather/chro...
tools/grit/grit/gather/chrome_html.py:299: attrs['preprocess'] == 'true')
nit: indent off

https://codereview.chromium.org/2014793002/diff/1/tools/grit/grit/node/includ...
File tools/grit/grit/node/include.py (right):

https://codereview.chromium.org/2014793002/diff/1/tools/grit/grit/node/includ...
tools/grit/grit/node/include.py:38: preprocess_only=False,
isn't this the default?

[Lei Zhang, 2016-05-26 02:08:16]

https://codereview.chromium.org/2014793002/diff/1/tools/grit/grit/gather/chro...
File tools/grit/grit/gather/chrome_html.py (right):

https://codereview.chromium.org/2014793002/diff/1/tools/grit/grit/gather/chro...
tools/grit/grit/gather/chrome_html.py:302: self.preprocess_only_)
Check this first since it's less processing?

https://codereview.chromium.org/2014793002/diff/1/tools/grit/grit/node/struct...
File tools/grit/grit/node/structure.py (right):

https://codereview.chromium.org/2014793002/diff/1/tools/grit/grit/node/struct...
tools/grit/grit/node/structure.py:141: 'preprocess': 'false',
Maybe add a comment somewhere to say preprocess implies flattenhtml?

[groby-ooo-7-16, 2016-05-26 02:10:17]

https://codereview.chromium.org/2014793002/diff/1/tools/grit/grit/node/includ...
File tools/grit/grit/node/include.py (right):

https://codereview.chromium.org/2014793002/diff/1/tools/grit/grit/node/includ...
tools/grit/grit/node/include.py:38: preprocess_only=False,
On 2016/05/26 02:00:47, Dan Beam wrote:
> isn't this the default?

Yes. I'm however not very trusting when it comes to defaults :)

https://codereview.chromium.org/2014793002/diff/1/tools/grit/grit/node/struct...
File tools/grit/grit/node/structure.py (right):

https://codereview.chromium.org/2014793002/diff/1/tools/grit/grit/node/struct...
tools/grit/grit/node/structure.py:141: 'preprocess': 'false',
On 2016/05/26 02:08:16, Lei Zhang wrote:
> Maybe add a comment somewhere to say preprocess implies flattenhtml?

It doesn't, really. It takes the same path, which is why I set flattenhtml, but
that's more an artifact of how the code is structured. (I'd prefer it if flatten
implied preprocess, but the code is tricky enough that I'm not looking to change
the structure to support that)

If you still want a comment here, LMK

[Lei Zhang, 2016-05-26 02:20:36]

https://codereview.chromium.org/2014793002/diff/1/tools/grit/grit/node/struct...
File tools/grit/grit/node/structure.py (right):

https://codereview.chromium.org/2014793002/diff/1/tools/grit/grit/node/struct...
tools/grit/grit/node/structure.py:141: 'preprocess': 'false',
On 2016/05/26 02:10:17, groby wrote:
> On 2016/05/26 02:08:16, Lei Zhang wrote:
> > Maybe add a comment somewhere to say preprocess implies flattenhtml?
> 
> It doesn't, really. It takes the same path, which is why I set flattenhtml,
but
> that's more an artifact of how the code is structured. (I'd prefer it if
flatten
> implied preprocess, but the code is tricky enough that I'm not looking to
change
> the structure to support that)
> 
> If you still want a comment here, LMK

Comments are always good. "preprocess" can mean different things to different
people.

[groby-ooo-7-16, 2016-05-26 02:26:35]

https://codereview.chromium.org/2014793002/diff/1/tools/grit/grit/node/struct...
File tools/grit/grit/node/structure.py (right):

https://codereview.chromium.org/2014793002/diff/1/tools/grit/grit/node/struct...
tools/grit/grit/node/structure.py:141: 'preprocess': 'false',
On 2016/05/26 02:20:36, Lei Zhang wrote:
> On 2016/05/26 02:10:17, groby wrote:
> > On 2016/05/26 02:08:16, Lei Zhang wrote:
> > > Maybe add a comment somewhere to say preprocess implies flattenhtml?
> > 
> > It doesn't, really. It takes the same path, which is why I set flattenhtml,
> but
> > that's more an artifact of how the code is structured. (I'd prefer it if
> flatten
> > implied preprocess, but the code is tricky enough that I'm not looking to
> change
> > the structure to support that)
> > 
> > If you still want a comment here, LMK
> 
> Comments are always good. "preprocess" can mean different things to different
> people.

There ya go :)

[Lei Zhang, 2016-05-26 02:32:28]

https://codereview.chromium.org/2014793002/diff/20001/tools/grit/grit/gather/...
File tools/grit/grit/gather/chrome_html.py (right):

https://codereview.chromium.org/2014793002/diff/20001/tools/grit/grit/gather/...
tools/grit/grit/gather/chrome_html.py:299: attrs['preprocess'] == 'true')
indentation still

[groby-ooo-7-16, 2016-05-26 02:45:21]

https://codereview.chromium.org/2014793002/diff/1/tools/grit/grit/gather/chro...
File tools/grit/grit/gather/chrome_html.py (right):

https://codereview.chromium.org/2014793002/diff/1/tools/grit/grit/gather/chro...
tools/grit/grit/gather/chrome_html.py:302: self.preprocess_only_)
On 2016/05/26 02:08:15, Lei Zhang wrote:
> Check this first since it's less processing?

Done.

https://codereview.chromium.org/2014793002/diff/20001/tools/grit/grit/gather/...
File tools/grit/grit/gather/chrome_html.py (right):

https://codereview.chromium.org/2014793002/diff/20001/tools/grit/grit/gather/...
tools/grit/grit/gather/chrome_html.py:299: attrs['preprocess'] == 'true')
On 2016/05/26 02:32:28, Lei Zhang wrote:
> indentation still

Done.

[Lei Zhang, 2016-05-26 02:49:41]

lgtm

[Lei Zhang, 2016-05-26 02:49:45]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-05-26 02:49:45]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2014793002/#ps50001
(title: "Review fixes.")

[commit-bot: I haz the power, 2016-05-26 02:50:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014793002/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014793002/50001

[commit-bot: I haz the power, 2016-05-26 03:44:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-26 03:44:34]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Lei Zhang, 2016-05-26 03:58:53]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-05-26 03:59:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014793002/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014793002/50001

[commit-bot: I haz the power, 2016-05-26 04:27:10]

Description was changed from

==========
[Grit] Allow preprocess-only "inlining"

Grit inlining is occasionally more than necessary - sometimes, all
that's needed is processing of <if> and <include> directives, without
following every html reference.

(One specific case: When the HTML refers to relative resources. Grit
tries to treat them as files, since no protocol is specified)

This change adds support for the "preprocess" attribute, which disables
link inlining.

R=thestig@chromium.org
BUG=none
==========

to

==========
[Grit] Allow preprocess-only "inlining"

Grit inlining is occasionally more than necessary - sometimes, all
that's needed is processing of <if> and <include> directives, without
following every html reference.

(One specific case: When the HTML refers to relative resources. Grit
tries to treat them as files, since no protocol is specified)

This change adds support for the "preprocess" attribute, which disables
link inlining.

R=thestig@chromium.org
BUG=none
==========

[commit-bot: I haz the power, 2016-05-26 04:27:11]

Committed patchset #4 (id:50001)

[commit-bot: I haz the power, 2016-05-26 04:30:01]

Description was changed from

==========
[Grit] Allow preprocess-only "inlining"

Grit inlining is occasionally more than necessary - sometimes, all
that's needed is processing of <if> and <include> directives, without
following every html reference.

(One specific case: When the HTML refers to relative resources. Grit
tries to treat them as files, since no protocol is specified)

This change adds support for the "preprocess" attribute, which disables
link inlining.

R=thestig@chromium.org
BUG=none
==========

to

==========
[Grit] Allow preprocess-only "inlining"

Grit inlining is occasionally more than necessary - sometimes, all
that's needed is processing of <if> and <include> directives, without
following every html reference.

(One specific case: When the HTML refers to relative resources. Grit
tries to treat them as files, since no protocol is specified)

This change adds support for the "preprocess" attribute, which disables
link inlining.

R=thestig@chromium.org
BUG=none

Committed: https://crrev.com/72ed2672c529ba14ff68b3f69c2c211b058bfee4
Cr-Commit-Position: refs/heads/master@{#396119}
==========

[commit-bot: I haz the power, 2016-05-26 04:30:02]

Patchset 4 (id:??) landed as
https://crrev.com/72ed2672c529ba14ff68b3f69c2c211b058bfee4
Cr-Commit-Position: refs/heads/master@{#396119}