Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2014783002: Enable WebApkServiceConnectionManagerTest (Closed)

Created:
4 years, 6 months ago by pkotwicz
Modified:
4 years, 6 months ago
Reviewers:
Xi Han
CC:
chromium-reviews, Yaron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable WebApkServiceConnectionManagerTest BUG=611421 Committed: https://crrev.com/a817f866063e59aa5cf15a57db9e126ec27d62f8 Cr-Commit-Position: refs/heads/master@{#396252}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/android/webapk/libs/client/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pkotwicz
Xi can you please take a look? I seem to have missed this in https://codereview.chromium.org/1969303002/
4 years, 6 months ago (2016-05-26 01:41:16 UTC) #2
Xi Han
lgtm
4 years, 6 months ago (2016-05-26 18:12:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014783002/1
4 years, 6 months ago (2016-05-26 18:14:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-26 19:26:32 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-26 19:28:57 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a817f866063e59aa5cf15a57db9e126ec27d62f8
Cr-Commit-Position: refs/heads/master@{#396252}

Powered by Google App Engine
This is Rietveld 408576698