Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: docs/clang.md

Issue 2014753002: Update build instructions for Linux and Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | docs/linux_build_instructions.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/clang.md
diff --git a/docs/clang.md b/docs/clang.md
index 4e12a7e48c05c4b533bdfe3566f70d4aba2b024b..c1cbaacb5a88fb4fd33dd21d0a7fce091be49745 100644
--- a/docs/clang.md
+++ b/docs/clang.md
@@ -33,10 +33,8 @@ Build: `ninja -C out/Debug chrome`
## Reverting to gcc on linux
We don't have bots that test this, but building with gcc4.8+ should still work
-on Linux. If your system gcc is new enough, use this to build with gcc if you
-don't want to build with clang:
-
- GYP_DEFINES=clang=0 build/gyp_chromium
+on Linux. If your system gcc is new enough, run `gn args` and add `is_clang =
+false`.
## Mailing List
@@ -62,7 +60,7 @@ To test the FindBadConstructs plugin, run:
../../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so)
To run [other plugins](writing_clang_plugins.md), add these to your
-`GYP_DEFINES`:
+`GYP_DEFINES` (this is not currently set up in GN):
* `clang_load`: Absolute path to a dynamic library containing your plugin
* `clang_add_plugin`: tells clang to run a specific PluginASTAction
« no previous file with comments | « no previous file | docs/linux_build_instructions.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698