Removing parsing of text from pasteboard.

chrome/browser/ui/cocoa/url_drop_target.mm

Index: chrome/browser/ui/cocoa/url_drop_target.mm
diff --git a/chrome/browser/ui/cocoa/url_drop_target.mm b/chrome/browser/ui/cocoa/url_drop_target.mm
index 00b11c1c9d60a84df24213e6891ea63880c0eacd..1bca23e90b0596db2692fbd7adfee052ead18827 100644
--- a/chrome/browser/ui/cocoa/url_drop_target.mm
+++ b/chrome/browser/ui/cocoa/url_drop_target.mm
@@ -84,10 +84,10 @@
   NSPoint dropPoint =
       [view_ convertPoint:[sender draggingLocation] fromView:nil];
   // Tell the window controller about the dropped URL(s).
-  if ([pboard containsURLData]) {
+  if ([pboard containsURLDataInType]) {

[erikchen, 2016/05/26 21:01:18]

I don't think this is the right approach. If a user drag and drops a a plain
text URL stored in a NSStringPboardType from another application into Chrome, it
should still be interpreted as a URL. 

I'm surprised that your newly added test UrlDropControllerTest.DragAndDropURL
passes. It is because you're using ui::ClipboardUtil::PasteboardItemFromUrls,
which internally uses NSPasteboardTypeString, which Pasteboard is smart with,
and converts into a URL type?

It looks like the problem is that the methods 
"""
- (void) getURLs:(NSArray**)outUrls	 
            andTitles:(NSArray**)outTitles
    convertingFilenames:(BOOL)convertFilenames;
- (BOOL)containsURLData;
"""
are trying to perform some URI cleanup with a hacked together method
cleanedStringWithPasteboardString: which trims whitespace, and does some other
nonsensical stuff.

I think the right solution is:
1. Expand the function ClipboardUtil::URLsAndTitlesFromPasteboard in
ui/base/clipboard/clipboard_util_mac.mm to handle more Pboard URIs, to better
match the behavior of:
"""
- (void) getURLs:(NSArray**)outUrls	 
            andTitles:(NSArray**)outTitles
    convertingFilenames:(BOOL)convertFilenames;
"""

Use functions from GURL to determine whether the url is valid. Note that this
will require a new dependency from ui/base/clipboard/DEPS onto url/. I think
this is okay, but check with avi@ and an OWNER of url/.

2. Replace the call here to [pboard containsURLData] with an appropriate call to
ClipboardUtil::URLsAndTitlesFromPasteboard.

     NSArray* urls = nil;
     NSArray* titles;  // discarded
-    [pboard getURLs:&urls andTitles:&titles convertingFilenames:YES];
+    [pboard getURLsFromType:&urls andTitles:&titles convertingFilenames:YES];
 
     if ([urls count]) {
       [[view_ urlDropController] dropURLs:urls inView:view_ at:dropPoint];
@@ -111,7 +111,7 @@
   NSPasteboard* pboard = [sender draggingPasteboard];
   NSArray *supportedTypes = [NSArray arrayWithObjects:NSStringPboardType, nil];
   NSString *bestType = [pboard availableTypeFromArray:supportedTypes];
-  if (![pboard containsURLData] && ![pboard stringForType:bestType])
+  if (![pboard containsURLDataInType] && ![pboard stringForType:bestType])
     return NSDragOperationNone;
 
   // Only allow the copy operation.