Move webcursors code from webkit/ to content.

Move webcursors code from webkit/ to content.

BUG=265753, 338338, 237249
TEST=content_unittests
R=jam@chromium.org, torne@chromium.org
TBR=darin

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258169

[jam, 2014-03-17 19:56:23]

content lgtm with comments addressed

https://codereview.chromium.org/201473002/diff/20001/android_webview/tools/th...
File android_webview/tools/third_party_files_whitelist.txt (right):

https://codereview.chromium.org/201473002/diff/20001/android_webview/tools/th...
android_webview/tools/third_party_files_whitelist.txt:187:
content/common/cursors/webcursor_gtk_data.h
you should add an owner from this directory for this, i'm not familiar with it
to know if we still need that line or not

https://codereview.chromium.org/201473002/diff/20001/content/common/cursors/DEPS
File content/common/cursors/DEPS (right):

https://codereview.chromium.org/201473002/diff/20001/content/common/cursors/D...
content/common/cursors/DEPS:4: "+ui/base/resource",
can't do this, see the comment in

content/DEPS


91	  # Content knows about grd files, but the specifics of how to get a resource
92	  # given its id is left to the embedder.
93	  "-ui/base/l10n",
94	  "-ui/base/resource",

instead, use GetContentClient()->GetNativeImageNamed in webcursor_mac.mm instead
of calling out to ResourceBundle.

https://codereview.chromium.org/201473002/diff/20001/content/common/cursors/w...
File content/common/cursors/webcursor.h (right):

https://codereview.chromium.org/201473002/diff/20001/content/common/cursors/w...
content/common/cursors/webcursor.h:43: class CONTENT_EXPORT WebCursor {
need to put this in the content namespace

[tfarina, 2014-03-19 03:22:34]

Richard, could you review my changes in android_webview?

[tfarina, 2014-03-19 04:17:18]

https://codereview.chromium.org/201473002/diff/20001/content/common/cursors/DEPS
File content/common/cursors/DEPS (right):

https://codereview.chromium.org/201473002/diff/20001/content/common/cursors/D...
content/common/cursors/DEPS:4: "+ui/base/resource",
On 2014/03/17 19:56:24, jam wrote:
> can't do this, see the comment in
> 
> content/DEPS
> 
> 
> 91	  # Content knows about grd files, but the specifics of how to get a
resource
> 92	  # given its id is left to the embedder.
> 93	  "-ui/base/l10n",
> 94	  "-ui/base/resource",
> 
> instead, use GetContentClient()->GetNativeImageNamed in webcursor_mac.mm
instead
> of calling out to ResourceBundle.

Done.

https://codereview.chromium.org/201473002/diff/20001/content/common/cursors/w...
File content/common/cursors/webcursor.h (right):

https://codereview.chromium.org/201473002/diff/20001/content/common/cursors/w...
content/common/cursors/webcursor.h:43: class CONTENT_EXPORT WebCursor {
On 2014/03/17 19:56:24, jam wrote:
> need to put this in the content namespace

Done.

[Torne, 2014-03-19 10:49:55]

android_webview LGTM

[tfarina, 2014-03-19 14:07:47]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2014-03-19 14:07:50]

The CQ bit was unchecked by tfarina@chromium.org

[tfarina, 2014-03-19 14:08:51]

TBRing Darin for webkit/ changes.

[tfarina, 2014-03-19 14:10:30]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-03-19 14:10:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/201473002/40001

[commit-bot: I haz the power, 2014-03-19 14:32:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-19 14:32:16]

Try jobs failed on following builders:
  tryserver.chromium on mac_chromium_rel

[tfarina, 2014-03-19 22:05:54]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-03-19 22:06:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/201473002/60001

[commit-bot: I haz the power, 2014-03-19 22:12:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-19 22:12:42]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_clang_dbg

[tfarina, 2014-03-19 22:22:06]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-03-19 22:23:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/201473002/60001

[commit-bot: I haz the power, 2014-03-19 22:27:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-19 22:27:03]

Try jobs failed on following builders:
  tryserver.chromium on linux_chromium_clang_dbg

[tfarina, 2014-03-19 23:07:10]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-03-19 23:10:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/201473002/80001

[commit-bot: I haz the power, 2014-03-19 23:40:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-19 23:40:48]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[tfarina, 2014-03-20 00:11:25]

Committed patchset #5 manually as r258169 (presubmit successful).