Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: base/android/java/src/org/chromium/base/BuildInfo.java

Issue 2014693003: Includes GMS version in crash report. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: changed variable name; remove empty message Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/java/src/org/chromium/base/BuildInfo.java
diff --git a/base/android/java/src/org/chromium/base/BuildInfo.java b/base/android/java/src/org/chromium/base/BuildInfo.java
index f55c35e78b7f39b61528297d02a574b7cfdacc20..eb5475b2a347f0c1c7d6e42318b5c4e3159fd16c 100644
--- a/base/android/java/src/org/chromium/base/BuildInfo.java
+++ b/base/android/java/src/org/chromium/base/BuildInfo.java
@@ -10,7 +10,6 @@ import android.content.pm.PackageInfo;
import android.content.pm.PackageManager;
import android.content.pm.PackageManager.NameNotFoundException;
import android.os.Build;
-import android.util.Log;
import org.chromium.base.annotations.CalledByNative;
@@ -67,6 +66,21 @@ public class BuildInfo {
}
@CalledByNative
+ public static String getGMSVersionCode(Context context) {
+ String msg = "gms versionCode not available.";
+ try {
+ PackageManager packageManager = context.getPackageManager();
+ PackageInfo packageInfo = packageManager.getPackageInfo("com.google.android.gms", 0);
+ if (packageInfo.versionCode > 0) {
Torne 2016/06/03 14:10:10 Seems like there isn't much point in doing this; w
BigBossZhiling 2016/06/09 22:19:59 Done.
+ msg = Integer.toString(packageInfo.versionCode);
+ }
+ } catch (NameNotFoundException e) {
+ Log.d(TAG, "Error when trying to get gms version code: %s", e);
Torne 2016/06/03 14:10:10 I'd probably just have this explicitly set msg to
BigBossZhiling 2016/06/09 22:19:59 Done.
+ }
+ return msg;
+ }
+
+ @CalledByNative
public static String getPackageVersionCode(Context context) {
String msg = "versionCode not available.";
try {

Powered by Google App Engine
This is Rietveld 408576698