Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: base/android/build_info.h

Issue 2014693003: Includes GMS version in crash report. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/android/build_info.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_ANDROID_BUILD_INFO_H_ 5 #ifndef BASE_ANDROID_BUILD_INFO_H_
6 #define BASE_ANDROID_BUILD_INFO_H_ 6 #define BASE_ANDROID_BUILD_INFO_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 } 67 }
68 68
69 const char* android_build_id() const { 69 const char* android_build_id() const {
70 return android_build_id_; 70 return android_build_id_;
71 } 71 }
72 72
73 const char* android_build_fp() const { 73 const char* android_build_fp() const {
74 return android_build_fp_; 74 return android_build_fp_;
75 } 75 }
76 76
77 const char* gms_version_code() const {
78 return gms_version_code_;
79 }
80
77 const char* package_version_code() const { 81 const char* package_version_code() const {
78 return package_version_code_; 82 return package_version_code_;
79 } 83 }
80 84
81 const char* package_version_name() const { 85 const char* package_version_name() const {
82 return package_version_name_; 86 return package_version_name_;
83 } 87 }
84 88
85 const char* package_label() const { 89 const char* package_label() const {
86 return package_label_; 90 return package_label_;
(...skipping 29 matching lines...) Expand all
116 // Const char* is used instead of std::strings because these values must be 120 // Const char* is used instead of std::strings because these values must be
117 // available even if the process is in a crash state. Sadly 121 // available even if the process is in a crash state. Sadly
118 // std::string.c_str() doesn't guarantee that memory won't be allocated when 122 // std::string.c_str() doesn't guarantee that memory won't be allocated when
119 // it is called. 123 // it is called.
120 const char* const device_; 124 const char* const device_;
121 const char* const manufacturer_; 125 const char* const manufacturer_;
122 const char* const model_; 126 const char* const model_;
123 const char* const brand_; 127 const char* const brand_;
124 const char* const android_build_id_; 128 const char* const android_build_id_;
125 const char* const android_build_fp_; 129 const char* const android_build_fp_;
130 const char* const gms_version_code_;
126 const char* const package_version_code_; 131 const char* const package_version_code_;
127 const char* const package_version_name_; 132 const char* const package_version_name_;
128 const char* const package_label_; 133 const char* const package_label_;
129 const char* const package_name_; 134 const char* const package_name_;
130 const char* const build_type_; 135 const char* const build_type_;
131 const int sdk_int_; 136 const int sdk_int_;
132 // This is set via set_java_exception_info, not at constructor time. 137 // This is set via set_java_exception_info, not at constructor time.
133 const char* java_exception_info_; 138 const char* java_exception_info_;
134 139
135 DISALLOW_COPY_AND_ASSIGN(BuildInfo); 140 DISALLOW_COPY_AND_ASSIGN(BuildInfo);
136 }; 141 };
137 142
138 } // namespace android 143 } // namespace android
139 } // namespace base 144 } // namespace base
140 145
141 #endif // BASE_ANDROID_BUILD_INFO_H_ 146 #endif // BASE_ANDROID_BUILD_INFO_H_
OLDNEW
« no previous file with comments | « no previous file | base/android/build_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698