Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: components/crash/content/app/breakpad_linux.cc

Issue 2014693003: Includes GMS version in crash report. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: changed variable name; remove empty message Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // For linux_syscall_support.h. This makes it safe to call embedded system 5 // For linux_syscall_support.h. This makes it safe to call embedded system
6 // calls when in seccomp mode. 6 // calls when in seccomp mode.
7 7
8 #include "components/crash/content/app/breakpad_linux.h" 8 #include "components/crash/content/app/breakpad_linux.h"
9 9
10 #include <fcntl.h> 10 #include <fcntl.h>
(...skipping 585 matching lines...) Expand 10 before | Expand all | Expand 10 after
596 base::android::BuildInfo* android_build_info = 596 base::android::BuildInfo* android_build_info =
597 base::android::BuildInfo::GetInstance(); 597 base::android::BuildInfo::GetInstance();
598 598
599 AndroidLogWriteHorizontalRule(); 599 AndroidLogWriteHorizontalRule();
600 __android_log_write(ANDROID_LOG_WARN, kGoogleBreakpad, 600 __android_log_write(ANDROID_LOG_WARN, kGoogleBreakpad,
601 "Chrome build fingerprint:"); 601 "Chrome build fingerprint:");
602 __android_log_write(ANDROID_LOG_WARN, kGoogleBreakpad, 602 __android_log_write(ANDROID_LOG_WARN, kGoogleBreakpad,
603 android_build_info->package_version_name()); 603 android_build_info->package_version_name());
604 __android_log_write(ANDROID_LOG_WARN, kGoogleBreakpad, 604 __android_log_write(ANDROID_LOG_WARN, kGoogleBreakpad,
605 android_build_info->package_version_code()); 605 android_build_info->package_version_code());
606 __android_log_write(ANDROID_LOG_WARN, kGoogleBreakpad,
dgn 2016/05/27 09:09:19 The output is going to be something like: Chrom
607 android_build_info->gms_version_code());
606 AndroidLogWriteHorizontalRule(); 608 AndroidLogWriteHorizontalRule();
607 609
608 if (!is_browser_process && 610 if (!is_browser_process &&
609 android_build_info->sdk_int() >= 18 && 611 android_build_info->sdk_int() >= 18 &&
610 my_strcmp(android_build_info->build_type(), "eng") != 0 && 612 my_strcmp(android_build_info->build_type(), "eng") != 0 &&
611 my_strcmp(android_build_info->build_type(), "userdebug") != 0) { 613 my_strcmp(android_build_info->build_type(), "userdebug") != 0) {
612 // On JB MR2 and later, the system crash handler displays a dialog. For 614 // On JB MR2 and later, the system crash handler displays a dialog. For
613 // renderer crashes, this is a bad user experience and so this is disabled 615 // renderer crashes, this is a bad user experience and so this is disabled
614 // for user builds of Android. 616 // for user builds of Android.
615 // TODO(cjhopman): There should be some way to recover the crash stack from 617 // TODO(cjhopman): There should be some way to recover the crash stack from
(...skipping 1302 matching lines...) Expand 10 before | Expand all | Expand 10 after
1918 const std::string& gpu_fingerprint) { 1920 const std::string& gpu_fingerprint) {
1919 g_microdump_info.Get().SetGpuFingerprint(gpu_fingerprint); 1921 g_microdump_info.Get().SetGpuFingerprint(gpu_fingerprint);
1920 } 1922 }
1921 #endif // OS_ANDROID 1923 #endif // OS_ANDROID
1922 1924
1923 bool IsCrashReporterEnabled() { 1925 bool IsCrashReporterEnabled() {
1924 return g_is_crash_reporter_enabled; 1926 return g_is_crash_reporter_enabled;
1925 } 1927 }
1926 1928
1927 } // namespace breakpad 1929 } // namespace breakpad
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698