Issue 201463003: Avoid using getPresentationAttribute in ReferenceFilterBuilder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 201463003: Avoid using getPresentationAttribute in ReferenceFilterBuilder (Closed)

Created:
6 years, 9 months ago by rwlbuis

Modified:
6 years, 9 months ago

Reviewers:
pdr.

CC:
blink-reviews, krit, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, rwlbuis, Stephen Chennney, rune+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Avoid using getPresentationAttribute in ReferenceFilterBuilder Avoid using getPresentationAttribute in ReferenceFilterBuilder because it is deprecated, instead use getPropertyValue. This is the last internal use of getPresentationAttribute so a follow-up patch can remove it. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169780

Patch Set 1 #

Patch Set 2 : Fix logic #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	Source/core/rendering/svg/ReferenceFilterBuilder.cpp	View	1	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

rwlbuis

I think this makes sense, getPresentationAttribute has zero use according to http://www.chromestatus.com/metrics/feature/popularity . Even if ...

6 years, 9 months ago (2014-03-21 22:10:34 UTC) #1

pdr.

On 2014/03/21 22:10:34, rwlbuis wrote: > I think this makes sense, getPresentationAttribute has zero use ...

6 years, 9 months ago (2014-03-21 22:16:13 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/201463003/20001

6 years, 9 months ago (2014-03-21 22:20:03 UTC) #4

Message was sent while issue was closed.

Change committed as 169780

Expand Messages | Collapse Messages