Certificate Transparency: Wire the TreeStateTracker up.

chrome/browser/component_updater/sth_set_component_installer.h

Index: chrome/browser/component_updater/sth_set_component_installer.h
diff --git a/chrome/browser/component_updater/sth_set_component_installer.h b/chrome/browser/component_updater/sth_set_component_installer.h
index 4223aa371d544d355d2d13685196b8e28d09f46f..6de6f0ad2331bf423b0e4229c6f0d1b0b6dcaa75 100644
--- a/chrome/browser/component_updater/sth_set_component_installer.h
+++ b/chrome/browser/component_updater/sth_set_component_installer.h
@@ -40,8 +40,7 @@ class ComponentUpdateService;
 class STHSetComponentInstallerTraits : public ComponentInstallerTraits {
  public:
   // The |sth_distributor| will be notified each time a new STH is observed.
-  explicit STHSetComponentInstallerTraits(
-      std::unique_ptr<net::ct::STHObserver> sth_observer);
+  explicit STHSetComponentInstallerTraits(net::ct::STHObserver* sth_observer);
   ~STHSetComponentInstallerTraits() override;
 
  private:
@@ -73,7 +72,7 @@ class STHSetComponentInstallerTraits : public ComponentInstallerTraits {
   // STH parsing failed - do nothing.
   void OnJsonParseError(const std::string& log_id, const std::string& error);
 
-  std::unique_ptr<net::ct::STHObserver> sth_observer_;
+  net::ct::STHObserver* sth_observer_;

[Sorin Jianu, 2016/05/25 16:17:48]

Would it be possible to use a smart pointer? Same question for the constructor
parameter.

[Eran Messeri, 2016/05/25 16:26:18]

The two smart pointers I could use here are:
unique_ptr: Means passing ownership into STHSetComponentInstallerTraits, which,
as we discussed earlier, would complicate wiring and lifecycle management of
everything that's registered on it.
scoped_refptr: Means reference-counting the STHObserver. But because a global
object is now used to access it I don't see much value.

 
   DISALLOW_COPY_AND_ASSIGN(STHSetComponentInstallerTraits);
 };