Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2014563002: S390: Collect call counts for constructor calls, too. (Closed)

Created:
4 years, 7 months ago by john.yan
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Collect call counts for constructor calls, too. Port a6ddbef0645a944fc3d46d89af6362d585170348 Original commit message: The TurboFan inliner makes use of these counts. R=mvstanton@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Committed: https://crrev.com/4ce6c36ed8afe73b1fd1901a7ad96bc0bba8143d Cr-Commit-Position: refs/heads/master@{#36518}

Patch Set 1 #

Total comments: 1

Patch Set 2 : add kNear #

Patch Set 3 : another one #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -5 lines) Patch
M src/s390/assembler-s390.h View 1 chunk +1 line, -1 line 0 comments Download
M src/s390/code-stubs-s390.cc View 1 2 4 chunks +26 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
JoranSiu
lgtm with one minor comment. https://codereview.chromium.org/2014563002/diff/1/src/s390/code-stubs-s390.cc File src/s390/code-stubs-s390.cc (right): https://codereview.chromium.org/2014563002/diff/1/src/s390/code-stubs-s390.cc#newcode1890 src/s390/code-stubs-s390.cc:1890: __ beq(&done_increment_count); Can we ...
4 years, 7 months ago (2016-05-25 13:34:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014563002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014563002/40001
4 years, 7 months ago (2016-05-25 13:56:14 UTC) #4
john.yan
On 2016/05/25 13:34:11, JoranSiu wrote: > lgtm with one minor comment. > > https://codereview.chromium.org/2014563002/diff/1/src/s390/code-stubs-s390.cc > ...
4 years, 7 months ago (2016-05-25 13:56:14 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-25 14:26:03 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 14:28:04 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4ce6c36ed8afe73b1fd1901a7ad96bc0bba8143d
Cr-Commit-Position: refs/heads/master@{#36518}

Powered by Google App Engine
This is Rietveld 408576698