cc : Reland Add IsInIdtoIndexMap to property tres

cc : Reland Add IsInIdtoIndexMap to property tres

And use that to update during animations.
This patch also makes Layer::OnOpacityAnimated (and other animation
functions in LayerImpl) independent of property tree indices stored
on LayerImpl. This is needed to ensure we don't depend
on the order in which we push layer properties.

BUG=609208
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

patch from issue 1994333002 at patchset 60001 (http://crrev.com/1994333002#ps60001)

Committed: https://crrev.com/5d9c03a0e675528d3381753c3788d759202f4293
Cr-Commit-Position: refs/heads/master@{#396250}

[jaydasika, 2016-05-26 02:16:48]

Description was changed from

==========
cc : Reland Add IsInIdtoIndexMap to property tres

And use that to update during animations.
This patch also makes Layer::OnOpacityAnimated (and other animation
functions in LayerImpl) independent of property tree indices stored
on LayerImpl.

BUG=609208
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

patch from issue 1994333002 at patchset 60001
(http://crrev.com/1994333002#ps60001)
==========

to

==========
cc : Reland Add IsInIdtoIndexMap to property tres

And use that to update during animations.
This patch also makes Layer::OnOpacityAnimated (and other animation
functions in LayerImpl) independent of property tree indices stored
on LayerImpl. This is needed to ensure we don't depend
on the order in which we push layer properties.

BUG=609208
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

patch from issue 1994333002 at patchset 60001
(http://crrev.com/1994333002#ps60001)
==========

[jaydasika, 2016-05-26 02:17:06]

https://codereview.chromium.org/2014533005/diff/20001/cc/layers/scrollbar_lay...
File cc/layers/scrollbar_layer_unittest.cc (right):

https://codereview.chromium.org/2014533005/diff/20001/cc/layers/scrollbar_lay...
cc/layers/scrollbar_layer_unittest.cc:598: EXPECT_EQ(node->data.opacity, 1.f);
If we use effect tree index in LayerImpl::OnOpacityAnimated and keep the DCHECK
around, this tests will flakily fail the DCHECK.

[jaydasika, 2016-05-26 02:17:32]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, vollick@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-05-26 02:17:32]

PTAL

[jaydasika, 2016-05-26 02:23:08]

The original CL also caused a performance regression(crbug.com/613892). But, I
ran the perfbot again on one of the benchmarks reported in the regression and
din't see any regression. So maybe its gets noise(?)
(https://codereview.chromium.org/2006133003)

[ajuma, 2016-05-26 14:52:49]

On 2016/05/26 02:23:08, jaydasika wrote:
> The original CL also caused a performance regression(crbug.com/613892). But, I
> ran the perfbot again on one of the benchmarks reported in the regression and
> din't see any regression. So maybe its gets noise(?)
> (https://codereview.chromium.org/2006133003)

lgtm, but please keep an eye on the perf bots after this lands.

[jaydasika, 2016-05-26 16:13:05]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2016-05-26 16:13:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014533005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014533005/20001

[commit-bot: I haz the power, 2016-05-26 16:32:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-26 16:32:09]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[jaydasika, 2016-05-26 18:46:31]

The CQ bit was checked by jaydasika@chromium.org

[jaydasika, 2016-05-26 18:46:31]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/2014533005/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-05-26 18:47:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014533005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014533005/40001

[commit-bot: I haz the power, 2016-05-26 19:21:15]

Description was changed from

==========
cc : Reland Add IsInIdtoIndexMap to property tres

And use that to update during animations.
This patch also makes Layer::OnOpacityAnimated (and other animation
functions in LayerImpl) independent of property tree indices stored
on LayerImpl. This is needed to ensure we don't depend
on the order in which we push layer properties.

BUG=609208
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

patch from issue 1994333002 at patchset 60001
(http://crrev.com/1994333002#ps60001)
==========

to

==========
cc : Reland Add IsInIdtoIndexMap to property tres

And use that to update during animations.
This patch also makes Layer::OnOpacityAnimated (and other animation
functions in LayerImpl) independent of property tree indices stored
on LayerImpl. This is needed to ensure we don't depend
on the order in which we push layer properties.

BUG=609208
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

patch from issue 1994333002 at patchset 60001
(http://crrev.com/1994333002#ps60001)
==========

[commit-bot: I haz the power, 2016-05-26 19:21:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-26 19:22:24]

Description was changed from

==========
cc : Reland Add IsInIdtoIndexMap to property tres

And use that to update during animations.
This patch also makes Layer::OnOpacityAnimated (and other animation
functions in LayerImpl) independent of property tree indices stored
on LayerImpl. This is needed to ensure we don't depend
on the order in which we push layer properties.

BUG=609208
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

patch from issue 1994333002 at patchset 60001
(http://crrev.com/1994333002#ps60001)
==========

to

==========
cc : Reland Add IsInIdtoIndexMap to property tres

And use that to update during animations.
This patch also makes Layer::OnOpacityAnimated (and other animation
functions in LayerImpl) independent of property tree indices stored
on LayerImpl. This is needed to ensure we don't depend
on the order in which we push layer properties.

BUG=609208
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

patch from issue 1994333002 at patchset 60001
(http://crrev.com/1994333002#ps60001)

Committed: https://crrev.com/5d9c03a0e675528d3381753c3788d759202f4293
Cr-Commit-Position: refs/heads/master@{#396250}
==========

[commit-bot: I haz the power, 2016-05-26 19:22:27]

Patchset 3 (id:??) landed as
https://crrev.com/5d9c03a0e675528d3381753c3788d759202f4293
Cr-Commit-Position: refs/heads/master@{#396250}