Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2014523002: Reland of [keys] Simplify KeyAccumulator (Closed)

Created:
4 years, 7 months ago by Camillo Bruni
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [keys] Simplify KeyAccumulator (patchset #1 id:1 of https://codereview.chromium.org/2010593002/ ) Reason for revert: relanding, fixed handle dereferencing Original issue's description: > Revert of [keys] Simplify KeyAccumulator (patchset #15 id:280001 of https://codereview.chromium.org/1995263002/ ) > > Reason for revert: > https://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/6248 > > Original issue's description: > > [keys] Simplify KeyAccumulator > > > > - Use KeyAccumulator::GetKeys directly instead of JSReceiver::GetKeys > > - Revert KeyAccumulator to single OrderedHashSet implementation. > > - Convert the OrderedHashSet in-place to a FixedArray > > - IndexedInterceptor indices are no longer combined and sorted with the object indices > > > > BUG= > > > > Committed: https://crrev.com/d3324df017046bcde247a5aef6d1b59bfae5908f > > Cr-Commit-Position: refs/heads/master@{#36485} > > TBR=jkummerow@chromium.org,verwaest@chromium.org,cbruni@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/893524b53d43df63bca6cb9b7244d21771fadb0b > Cr-Commit-Position: refs/heads/master@{#36486} TBR=jkummerow@chromium.org,verwaest@chromium.org,machenbach@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/667188b1a782b26b71f80320c92b86fedcd382bc Cr-Commit-Position: refs/heads/master@{#36502}

Patch Set 1 #

Patch Set 2 : fixing wrong handle dereferencing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -427 lines) Patch
M src/api.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M src/builtins.cc View 1 5 chunks +8 lines, -8 lines 0 comments Download
M src/debug/debug-scopes.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/elements.cc View 1 13 chunks +68 lines, -51 lines 0 comments Download
M src/json-stringifier.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/keys.h View 1 5 chunks +22 lines, -41 lines 0 comments Download
M src/keys.cc View 1 9 chunks +104 lines, -274 lines 0 comments Download
M src/objects.h View 1 2 chunks +4 lines, -11 lines 0 comments Download
M src/objects.cc View 1 5 chunks +37 lines, -13 lines 0 comments Download
M src/objects-inl.h View 1 3 chunks +20 lines, -11 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime/runtime-forin.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api-interceptors.cc View 1 1 chunk +8 lines, -7 lines 0 comments Download
M test/mjsunit/es6/reflect.js View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Camillo Bruni
Created Reland of [keys] Simplify KeyAccumulator
4 years, 7 months ago (2016-05-25 09:11:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014523002/270001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014523002/270001
4 years, 7 months ago (2016-05-25 09:13:21 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:270001)
4 years, 7 months ago (2016-05-25 09:13:39 UTC) #4
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/667188b1a782b26b71f80320c92b86fedcd382bc Cr-Commit-Position: refs/heads/master@{#36502}
4 years, 7 months ago (2016-05-25 09:14:01 UTC) #6
Jakob Kummerow
4 years, 7 months ago (2016-05-25 09:55:48 UTC) #7
Message was sent while issue was closed.
LGTM. Please remember to clean up the auto-generated CL description next time
;-)

Powered by Google App Engine
This is Rietveld 408576698