Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: ui/keyboard/resources/elements/kb-keyboard.html

Issue 20145004: Switch from text insertion to key press and release events on the virtual k… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Formatting. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/keyboard/resources/elements/kb-keyboard.html
diff --git a/ui/keyboard/resources/elements/kb-keyboard.html b/ui/keyboard/resources/elements/kb-keyboard.html
index d21edf0d2144c0bec03df6ad0f16196947332183..34bea956b8570e21f9863a6bcfbe74638bef5e03 100644
--- a/ui/keyboard/resources/elements/kb-keyboard.html
+++ b/ui/keyboard/resources/elements/kb-keyboard.html
@@ -238,7 +238,10 @@
default:
break;
}
bshe 2013/07/25 15:33:05 Does this break multiple character keys like ".com
kevers 2013/07/26 00:53:30 Good catch. Fixed.
- insertText(char);
+ // Generate fabricated key events to simulate typing on a physical
+ // keybaord.
+ dispatchKeyEvent('keyPressed', char);
+ dispatchKeyEvent('keyReleased', char);
},
/*

Powered by Google App Engine
This is Rietveld 408576698