Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Issue 2014493002: Rename OwnPtr::clear() to reset() in web/. (Closed)

Created:
4 years, 7 months ago by Yuta Kitamura
Modified:
4 years, 7 months ago
Reviewers:
*haraken, *tzik
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename OwnPtr::clear() to reset() in web/. OwnPtr::clear() will soon get renamed to reset() as a part of OwnPtr-to-std::unique_ptr migration. BUG=611661 Committed: https://crrev.com/7c9532ef259fc4961a7c9e4220ec88ef3f1dea95 Cr-Commit-Position: refs/heads/master@{#395834}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M third_party/WebKit/Source/web/AssociatedURLLoader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/LinkHighlightImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDataSourceImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/SpinLockTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/WebHelperPluginTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
Yuta Kitamura
tzik: PTAL? +haraken for web/ approval
4 years, 7 months ago (2016-05-25 06:12:39 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014493002/1
4 years, 7 months ago (2016-05-25 06:13:00 UTC) #5
tzik
lgtm
4 years, 7 months ago (2016-05-25 06:20:27 UTC) #6
haraken
LGTM
4 years, 7 months ago (2016-05-25 06:59:09 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-25 08:29:51 UTC) #9
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-25 08:29:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014493002/1
4 years, 7 months ago (2016-05-25 08:33:38 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 08:38:27 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 08:41:18 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c9532ef259fc4961a7c9e4220ec88ef3f1dea95
Cr-Commit-Position: refs/heads/master@{#395834}

Powered by Google App Engine
This is Rietveld 408576698