Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 2014483002: Rename OwnPtr::clear() to reset() in bindings/. (Closed)

Created:
4 years, 7 months ago by Yuta Kitamura
Modified:
4 years, 7 months ago
Reviewers:
*haraken, *tzik
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename OwnPtr::clear() to reset() in bindings/. OwnPtr::clear() will soon get renamed to reset() as a part of OwnPtr-to-std::unique_ptr migration. BUG=611661 Committed: https://crrev.com/a2e6a0c352d0f2bd62a245d26abbad617e06cad3 Cr-Commit-Position: refs/heads/master@{#395827}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorld.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014483002/1
4 years, 7 months ago (2016-05-25 05:50:31 UTC) #5
Yuta Kitamura
tzik: PTAL? +haraken for bindings/ approval
4 years, 7 months ago (2016-05-25 05:50:33 UTC) #6
tzik
lgtm
4 years, 7 months ago (2016-05-25 05:55:34 UTC) #7
haraken
LGTM
4 years, 7 months ago (2016-05-25 06:58:28 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-25 07:30:10 UTC) #10
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-25 07:30:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014483002/1
4 years, 7 months ago (2016-05-25 07:34:23 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-25 07:49:28 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 07:50:37 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2e6a0c352d0f2bd62a245d26abbad617e06cad3
Cr-Commit-Position: refs/heads/master@{#395827}

Powered by Google App Engine
This is Rietveld 408576698