[iOS/GN] Define targets to application extensions resources.

[iOS/GN] Define targets to application extensions resources.

Define targets that generate and pack resources for the application
extensions shipped with Chrome on iOS.

BUG=459705
Committed: https://crrev.com/bd27119c58aeabdcd78ebb856fe859919ea06acf
Cr-Commit-Position: refs/heads/master@{#396141}

[sdefresne, 2016-05-25 12:00:10]

sdefresne@chromium.org changed reviewers:
+ dpranke@chromium.org, justincohen@chromium.org

[sdefresne, 2016-05-25 12:00:10]

justincohen: Please take a look.
dpranke: please review the following as OWNERS for //BUILD.gn

[justincohen, 2016-05-25 14:23:56]

lgtm

https://codereview.chromium.org/2014473004/diff/1/ios/chrome/extension_repack...
File ios/chrome/extension_repack.gni (right):

https://codereview.chromium.org/2014473004/diff/1/ios/chrome/extension_repack...
ios/chrome/extension_repack.gni:77: # Use a locale variables to workaround this
issue.
Is this a bug?  crbug link?

[sdefresne, 2016-05-25 15:00:09]

https://codereview.chromium.org/2014473004/diff/1/ios/chrome/extension_repack...
File ios/chrome/extension_repack.gni (right):

https://codereview.chromium.org/2014473004/diff/1/ios/chrome/extension_repack...
ios/chrome/extension_repack.gni:77: # Use a locale variables to workaround this
issue.
On 2016/05/25 at 14:23:56, justincohen wrote:
> Is this a bug?  crbug link?

I think this is just a design decision AFAICT.

[Dirk Pranke, 2016-05-25 16:02:04]

lgtm

https://codereview.chromium.org/2014473004/diff/1/ios/chrome/extension_repack...
File ios/chrome/extension_repack.gni (right):

https://codereview.chromium.org/2014473004/diff/1/ios/chrome/extension_repack...
ios/chrome/extension_repack.gni:77: # Use a locale variables to workaround this
issue.
On 2016/05/25 15:00:09, sdefresne wrote:
> On 2016/05/25 at 14:23:56, justincohen wrote:
> > Is this a bug?  crbug link?
> 
> I think this is just a design decision AFAICT.

The GN grammar doesn't allow array access on scope fields, but it's not obvious
to me why we wouldn't want to allow this. Maybe file a bug to double-check?

[sdefresne, 2016-05-25 17:24:30]

On 2016/05/25 at 15:00:09, sdefresne wrote:
>
https://codereview.chromium.org/2014473004/diff/1/ios/chrome/extension_repack...
> File ios/chrome/extension_repack.gni (right):
> 
>
https://codereview.chromium.org/2014473004/diff/1/ios/chrome/extension_repack...
> ios/chrome/extension_repack.gni:77: # Use a locale variables to workaround
this issue.
> On 2016/05/25 at 14:23:56, justincohen wrote:
> > Is this a bug?  crbug link?
> 
> I think this is just a design decision AFAICT.

Filed https://bugs.chromium.org/p/chromium/issues/detail?id=614747.

[justincohen, 2016-05-25 17:28:47]

Still LGTM, plus please add reference to crbug.

[sdefresne, 2016-05-25 17:34:56]

On 2016/05/25 at 17:28:47, justincohen wrote:
> Still LGTM, plus please add reference to crbug.

Done.

[sdefresne, 2016-05-26 06:27:05]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-05-26 06:27:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, justincohen@chromium.org
Link to the patchset: https://codereview.chromium.org/2014473004/#ps20001
(title: "Add reference to bug")

[commit-bot: I haz the power, 2016-05-26 06:27:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014473004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014473004/20001

[commit-bot: I haz the power, 2016-05-26 07:37:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-26 07:38:53]

Description was changed from

==========
[iOS/GN] Define targets to application extensions resources.

Define targets that generate and pack resources for the application
extensions shipped with Chrome on iOS.

BUG=459705
==========

to

==========
[iOS/GN] Define targets to application extensions resources.

Define targets that generate and pack resources for the application
extensions shipped with Chrome on iOS.

BUG=459705

Committed: https://crrev.com/bd27119c58aeabdcd78ebb856fe859919ea06acf
Cr-Commit-Position: refs/heads/master@{#396141}
==========

[commit-bot: I haz the power, 2016-05-26 07:38:54]

Patchset 2 (id:??) landed as
https://crrev.com/bd27119c58aeabdcd78ebb856fe859919ea06acf
Cr-Commit-Position: refs/heads/master@{#396141}