third_party/WebKit/LayoutTests/bluetooth/requestDevice/name-empty-filter.html - Issue 2014473002: bluetooth: Web Bluetooth can filter by empty device names, doesn't leak MACs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/requestDevice/name-empty-filter.html

Issue 2014473002: bluetooth: Web Bluetooth can filter by empty device names, doesn't leak MACs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bt-GetNameOrEmpty-

Patch Set: addressed nits Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/requestDevice/name-empty-device-from-service-filter.html ('k') | third_party/WebKit/LayoutTests/bluetooth/requestDevice/name-missing-device-from-name-empty-filter.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/bluetooth/requestDevice/name-empty-filter.html

diff --git a/third_party/WebKit/LayoutTests/bluetooth/requestDevice/not-processing-user-gesture.html b/third_party/WebKit/LayoutTests/bluetooth/requestDevice/name-empty-filter.html

similarity index 56%

copy from third_party/WebKit/LayoutTests/bluetooth/requestDevice/not-processing-user-gesture.html

copy to third_party/WebKit/LayoutTests/bluetooth/requestDevice/name-empty-filter.html

index 908763cd49321226d0ba3916d4e7a4860638043d..0cfd7ef7e058c3a7514a29ab15d06c24a508b5a8 100644

--- a/third_party/WebKit/LayoutTests/bluetooth/requestDevice/not-processing-user-gesture.html

+++ b/third_party/WebKit/LayoutTests/bluetooth/requestDevice/name-empty-filter.html

@@ -6,8 +6,12 @@

'use strict';

promise_test(t => {

return setBluetoothFakeAdapter('HeartRateAdapter')

- .then(() => promise_rejects(

- t, 'SecurityError', navigator.bluetooth.requestDevice({

- filters: [{services: ['heart_rate']}]})));

-}, 'Requires a user gesture.');

+ .then(() => promise_rejects(

+ t, 'NotFoundError', requestDeviceWithKeyDown({

+ filters: [{

+ name: '',

+ services: ['heart_rate']

+ }]})));

+}, 'A named device is not matched by a filter with an empty name.');

</script>