bluetooth: Web Bluetooth can filter by empty device names, doesn't leak MACs.

content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_BLUETOOTH_ADAPTER_PROVIDER_H_
 #define CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_BLUETOOTH_ADAPTER_PROVIDER_H_
 
 #include <stdint.h>
 
 #include "base/callback.h"
@@ skipping 164 matching lines @@
   //         - Generic Access UUID (0x1800)
   //         - Heart Rate UUID (0x180d)
   //      - Services:
   //         - Generic Access Service - Characteristics as described in
   //           GetGenericAccessService.
   //         - Heart Rate Service - Characteristics as described in
   //           GetHeartRateService.
   static scoped_refptr<testing::NiceMock<device::MockBluetoothAdapter>>
   GetHeartRateAdapter();
 
+  // |GetEmptyNameHeartRateAdapter|
+  // Inherits from |EmptyAdapter|
+  // Internal Structure:
+  //   - Heart Rate Device
+  //      - UUIDs:
+  //         - Generic Access UUID (0x1800)
+  //         - Heart Rate UUID (0x180d)
+  //      - Services:
+  //         - Generic Access Service - Characteristics as described in
+  //           GetGenericAccessService.
+  //            - gap.device_name returns an empty string.
+  //         - Heart Rate Service - Characteristics as described in
+  //           GetHeartRateService.
+  static scoped_refptr<testing::NiceMock<device::MockBluetoothAdapter>>
+  GetEmptyNameHeartRateAdapter();
+
+  // |GetNoNameHeartRateAdapter|
+  // Inherits from |EmptyAdapter|
+  // Internal Structure:
+  //   - Heart Rate Device
+  //      - GetName returns base::null_opt.
+  //      - UUIDs:
+  //         - Generic Access UUID (0x1800)
+  //         - Heart Rate UUID (0x180d)
+  //      - Services:
+  //         - Generic Access Service - Characteristics as described in
+  //           GetGenericAccessService.
+  //            - gap.device_name returns an empty string.
+  //         - Heart Rate Service - Characteristics as described in
+  //           GetHeartRateService.
+  static scoped_refptr<testing::NiceMock<device::MockBluetoothAdapter>>
+  GetNoNameHeartRateAdapter();
+
   // |TwoHeartRateServicesAdapter|
   // Inherits from |EmptyAdapter|
   // Internal Structure:
   //   - Heart Rate Device
   //      - UUIDs:
   //         - Generic Access UUID (0x1800)
   //         - Heart Rate UUID (0x180d)
   //         - Heart Rate UUID (0x180d)
   //      - Services:
   //         - Generic Access Service - Characteristics as described in
@@ skipping 169 matching lines @@
   //      Returns: address
   //  - GetName:
   //      Returns: device_name.
   //  - IsPaired:
   //      Returns true.
   //  - ConnectGatt:
   //      Calls error callback with
   //      BluetoothDevice::ConnectErrorCode::ERROR_UNSUPPORTED_DEVICE.
   static std::unique_ptr<testing::NiceMock<device::MockBluetoothDevice>>
   GetBaseDevice(device::MockBluetoothAdapter* adapter,
-                const std::string& device_name = "Base Device",
+                const base::Optional<std::string>& device_name =
+                    base::Optional<std::string>("Base Device"),
                 device::BluetoothDevice::UUIDList uuids =
                     device::BluetoothDevice::UUIDList(),
                 const std::string& address = "00:00:00:00:00:00");
+  // Version without base::optional parameters, for simpler call sites:
+  static std::unique_ptr<testing::NiceMock<device::MockBluetoothDevice>>

[ortuno, 2016/07/31 18:00:05]

In the base::Optional documentation it says that we shouldn't use optional as a
function parameter[1] and should use a pointer instead. This will also avoid
having two variations of many functions. Also perhaps we don't need a default
value since all callers of this function pass in a name.


[1]
https://chromium.googlesource.com/chromium/src/+/master/docs/optional.md#When...

[scheib, 2016/08/02 03:24:33]

Done.

+  GetBaseDevice(device::MockBluetoothAdapter* adapter,
+                const std::string& device_name,
+                device::BluetoothDevice::UUIDList uuids =
+                    device::BluetoothDevice::UUIDList(),
+                const std::string& address = "00:00:00:00:00:00") {
+    return GetBaseDevice(adapter, base::make_optional(device_name), uuids,
+                         address);
+  }
 
   // |BatteryDevice|
   // Inherits from |BaseDevice|(adapter, "Battery Device", uuids,
   //                            "00:00:00:00:00:01")
   // UUIDs added:
   //   - Battery Service UUID (0x180F)
   // Services added:
   // None.
   static std::unique_ptr<testing::NiceMock<device::MockBluetoothDevice>>
   GetBatteryDevice(device::MockBluetoothAdapter* adapter);
@@ skipping 15 matching lines @@
   // UUIDs added:
   // None.
   // Services added:
   // None.
   // Mock Functions:
   //   - CreateGattConnection:
   //       - Run success callback with BaseGATTConnection
   static std::unique_ptr<testing::NiceMock<device::MockBluetoothDevice>>
   GetConnectableDevice(
       device::MockBluetoothAdapter* adapter,
-      const std::string& device_name = "Connectable Device",
+      const base::Optional<std::string>& device_name =
+          base::Optional<std::string>("Connectable Device"),
       device::BluetoothDevice::UUIDList = device::BluetoothDevice::UUIDList(),
       const std::string& address = "00:00:00:00:00:00");
+  // Version without base::optional parameters, for simpler call sites:
+  static std::unique_ptr<testing::NiceMock<device::MockBluetoothDevice>>
+  GetConnectableDevice(device::MockBluetoothAdapter* adapter,
+                       const std::string& device_name,
+                       device::BluetoothDevice::UUIDList uuids =
+                           device::BluetoothDevice::UUIDList(),
+                       const std::string& address = "00:00:00:00:00:00") {
+    return GetConnectableDevice(adapter, base::make_optional(device_name),
+                                uuids, address);
+  }
 
   // |UnconnectableDevice|
   // Inherits from |BaseDevice|(adapter, device_name)
   // UUIDs added:
   //  - errorUUID(error_code)
   // Services added:
   // None.
   // Mock Functions:
   //  - CreateGATTConnection:
   //      - Run error callback with error_type
   static std::unique_ptr<testing::NiceMock<device::MockBluetoothDevice>>
   GetUnconnectableDevice(
       device::MockBluetoothAdapter* adapter,
       device::BluetoothDevice::ConnectErrorCode error_code,
       const std::string& device_name = "Unconnectable Device");
 
   // |HeartRateDevice|
   // Inherits from |ConnectableDevice|(adapter, "Heart Rate Device", uuids)
   // UUIDs added:
   //   - Generic Access (0x1800)
   //   - Heart Rate UUID (0x180D)
   // Services added:
   // None. Each user of the HeartRateDevice is in charge of adding the
   // relevant services, characteristics and descriptors.
   static std::unique_ptr<testing::NiceMock<device::MockBluetoothDevice>>
-  GetHeartRateDevice(device::MockBluetoothAdapter* adapter);
+  GetHeartRateDevice(device::MockBluetoothAdapter* adapter,
+                     const base::Optional<std::string>& device_name =
+                         base::Optional<std::string>("Heart Rate Device"));
 
   // Services
 
   // |BaseGATTService|(identifier, device, uuid)
   // Characteristics added:
   // None.
   // Mock Functions:
   //   - GetCharacteristics:
   //       Returns a list with all the characteristics added to the service
   //   - GetCharacteristic:
@@ skipping 171 matching lines @@
 
   // Function to turn an integer into an MAC address of the form
   // XX:XX:XX:XX:XX:XX. For example makeMACAddress(0xdeadbeef)
   // returns "00:00:DE:AD:BE:EF".
   static std::string makeMACAddress(uint64_t addr);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_BLUETOOTH_ADAPTER_PROVIDER_H_