bluetooth: Web Bluetooth can filter by empty device names, doesn't leak MACs.

content/browser/bluetooth/bluetooth_device_chooser_controller.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/bluetooth/bluetooth_device_chooser_controller.h"
 
 #include <set>
 #include <string>
 #include <unordered_set>
 
@@ skipping 72 matching lines @@
   return filters.empty()
              ? true
              : filters.end() != std::find_if(filters.begin(), filters.end(),
                                              IsEmptyOrInvalidFilter);
 }
 
 bool MatchesFilter(const device::BluetoothDevice& device,
                    const blink::mojom::WebBluetoothScanFilterPtr& filter) {
   DCHECK(!IsEmptyOrInvalidFilter(filter));
 
-  // TODO(615720): Use the upcoming GetName (was GetDeviceName).
-  const std::string device_name = base::UTF16ToUTF8(device.GetNameForDisplay());
+  if (device.GetName()) {

[ortuno, 2016/07/21 17:42:29]

If a device doesn't have a name and name is the only member in our filter, we
will match the device. Which I think is wrong. I think the logic should be:

if (!filter->name.is_null()) {
  if (!(device.GetName() && filter->name == device.GetName().value())) {
    return false;
  }
}

if (!filter->namePrefix.is_null()) {
  if (!(device.GetName() && base::StartsWith(filter->name_prefix.get(),
device.GetName().value()))) {
    return false;
  }
}

Which is requires some thinking so I think we need some exhaustive tests for
this.

[scheib, 2016/07/30 02:38:13]

Done.

+    if (!filter->name.is_null() && (device.GetName().value() != filter->name)) {
+      return false;
+    }
 
-  if (!filter->name.is_null() && (device_name != filter->name)) {
-    return false;
-  }
-
-  if (!filter->name_prefix.is_null() &&
-      (!base::StartsWith(device_name, filter->name_prefix.get(),
-                         base::CompareCase::SENSITIVE))) {
-    return false;
+    if (filter->name_prefix.size() &&
+        (!base::StartsWith(device.GetName().value(), filter->name_prefix.get(),
+                           base::CompareCase::SENSITIVE))) {
+      return false;
+    }
   }
 
   if (!filter->services.is_null()) {
     const auto& device_uuid_list = device.GetUUIDs();
     const std::unordered_set<BluetoothUUID, device::BluetoothUUIDHash>
         device_uuids(device_uuid_list.begin(), device_uuid_list.end());
     for (const base::Optional<BluetoothUUID>& service : filter->services) {
       if (!ContainsKey(device_uuids, service.value())) {
         return false;
       }
@@ skipping 365 matching lines @@
 
 void BluetoothDeviceChooserController::PostErrorCallback(
     blink::mojom::WebBluetoothError error) {
   if (!base::ThreadTaskRunnerHandle::Get()->PostTask(
           FROM_HERE, base::Bind(error_callback_, error))) {
     LOG(WARNING) << "No TaskRunner.";
   }
 }
 
 }  // namespace content