chrome/browser/first_run/first_run_internal_posix.cc - Issue 2014463003: Modifications for recording whether UMA/Crash default state for iOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/first_run/first_run_internal_posix.cc

Issue 2014463003: Modifications for recording whether UMA/Crash default state for iOS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix android include Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/metrics/uma_utils.cc ('k') | chrome/browser/metrics/chrome_metrics_service_client.cc » ('j') | components/metrics/metrics_reporting_default_state.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/first_run/first_run_internal_posix.cc

diff --git a/chrome/browser/first_run/first_run_internal_posix.cc b/chrome/browser/first_run/first_run_internal_posix.cc

index b69fdd28fbd30655dfe3214419649b08f7af93db..813136110cfc4f0d40c1ed9731df2ccb9c3a9eb6 100644

--- a/chrome/browser/first_run/first_run_internal_posix.cc

+++ b/chrome/browser/first_run/first_run_internal_posix.cc

@@ -11,12 +11,12 @@

#include "chrome/browser/browser_process.h"

#include "chrome/browser/first_run/first_run.h"

#include "chrome/browser/first_run/first_run_dialog.h"

-#include "chrome/browser/metrics/metrics_reporting_state.h"

#include "chrome/common/chrome_constants.h"

#include "chrome/common/chrome_paths.h"

#include "chrome/installer/util/google_update_settings.h"

#include "chrome/installer/util/master_preferences.h"

#include "components/metrics/metrics_pref_names.h"

+#include "components/metrics/metrics_reporting_default_state.h"

#include "components/prefs/pref_service.h"

#include "components/startup_metric_utils/browser/startup_metric_utils.h"

@@ -32,8 +32,9 @@ void DoPostImportPlatformSpecificTasks(Profile* profile) {

// has not already set preferences.

if (internal::IsOrganicFirstRun() && !local_state_file_exists) {

if (ShowFirstRunDialog(profile)) {

- RecordMetricsReportingDefaultOptIn(g_browser_process->local_state(),

- first_run::IsMetricsReportingOptIn());

+ metrics::RecordMetricsReportingDefaultOptIn(

+ g_browser_process->local_state(),

+ first_run::IsMetricsReportingOptIn());

startup_metric_utils::SetNonBrowserUIDisplayed();

}