Modifications for recording whether UMA/Crash default state for iOS

Modifications for recording whether UMA/Crash default state for iOS.

BUG=612828
Committed: https://crrev.com/06e66ef365cf2cd743640a8c110309de533c0d48
Cr-Commit-Position: refs/heads/master@{#398116}

[gayane -on leave until 09-2017, 2016-05-25 22:39:48]

Patchset #1 (id:1) has been deleted

[gayane -on leave until 09-2017, 2016-05-26 14:01:16]

Patchset #1 (id:20001) has been deleted

[gayane -on leave until 09-2017, 2016-05-26 14:02:21]

Patchset #1 (id:40001) has been deleted

[gayane -on leave until 09-2017, 2016-05-26 17:24:50]

Patchset #2 (id:80001) has been deleted

[gayane -on leave until 09-2017, 2016-05-26 17:51:35]

Description was changed from

==========
Record UMA default opt-out state for iOS

BUG=612828
==========

to

==========
Record whether UMA/Crash is opt-in by default for iOS

BUG=612828
==========

[gayane -on leave until 09-2017, 2016-05-26 17:57:37]

Description was changed from

==========
Record whether UMA/Crash is opt-in by default for iOS

BUG=612828
==========

to

==========
Modifications for recording whether UMA/Crash default state for iOS.

BUG=612828
==========

[gayane -on leave until 09-2017, 2016-05-26 18:00:06]

gayane@chromium.org changed reviewers:
+ asvitkine@chromium.org

[gayane -on leave until 09-2017, 2016-05-26 18:00:07]

Please have a look. Actual recording of the default bit would be in separate CL

[Alexei Svitkine (slow), 2016-05-26 19:24:15]

Looks good, just a few nits.

https://codereview.chromium.org/2014463003/diff/100001/components/metrics/met...
File components/metrics/metrics_reporting_default_state.cc (right):

https://codereview.chromium.org/2014463003/diff/100001/components/metrics/met...
components/metrics/metrics_reporting_default_state.cc:12:
registry->RegisterIntegerPref(metrics::prefs::kMetricsDefaultOptIn,
Nit: No need for metrics:: prefix. Remove it from all the places below too.

https://codereview.chromium.org/2014463003/diff/100001/components/metrics/met...
File components/metrics/metrics_reporting_default_state.h (right):

https://codereview.chromium.org/2014463003/diff/100001/components/metrics/met...
components/metrics/metrics_reporting_default_state.h:10: #include
"components/prefs/pref_service.h"
Nit: Forward declare the Prefs classes.

https://codereview.chromium.org/2014463003/diff/100001/components/metrics/met...
components/metrics/metrics_reporting_default_state.h:26:
metrics::MetricsServiceClient::EnableMetricsDefault
Nit: No need for metrics:: prefix

[gayane -on leave until 09-2017, 2016-05-26 20:33:37]

thanks. nits addressed

https://codereview.chromium.org/2014463003/diff/100001/components/metrics/met...
File components/metrics/metrics_reporting_default_state.cc (right):

https://codereview.chromium.org/2014463003/diff/100001/components/metrics/met...
components/metrics/metrics_reporting_default_state.cc:12:
registry->RegisterIntegerPref(metrics::prefs::kMetricsDefaultOptIn,
On 2016/05/26 19:24:15, Alexei Svitkine (slow) wrote:
> Nit: No need for metrics:: prefix. Remove it from all the places below too.

Done.

https://codereview.chromium.org/2014463003/diff/100001/components/metrics/met...
File components/metrics/metrics_reporting_default_state.h (right):

https://codereview.chromium.org/2014463003/diff/100001/components/metrics/met...
components/metrics/metrics_reporting_default_state.h:10: #include
"components/prefs/pref_service.h"
On 2016/05/26 19:24:15, Alexei Svitkine (slow) wrote:
> Nit: Forward declare the Prefs classes.

Done.

https://codereview.chromium.org/2014463003/diff/100001/components/metrics/met...
components/metrics/metrics_reporting_default_state.h:26:
metrics::MetricsServiceClient::EnableMetricsDefault
On 2016/05/26 19:24:15, Alexei Svitkine (slow) wrote:
> Nit: No need for metrics:: prefix

Done.

[gayane -on leave until 09-2017, 2016-05-26 20:36:01]

gayane@chromium.org changed reviewers:
+ lpromero@chromium.org, sky@chromium.org

[gayane -on leave until 09-2017, 2016-05-26 20:36:01]

lpromero@chromium.org: Please review changes in 
ios/chrome/browser/metrics/ios_chrome_metrics_service_client.cc

sky@chromium.org: Please review changes in 
chrome/browser/*

[Alexei Svitkine (slow), 2016-05-26 21:08:59]

lgtm

https://codereview.chromium.org/2014463003/diff/120001/components/metrics/met...
File components/metrics/metrics_reporting_default_state.h (right):

https://codereview.chromium.org/2014463003/diff/120001/components/metrics/met...
components/metrics/metrics_reporting_default_state.h:10: #include
"components/prefs/pref_service.h"
Nit: Move these #includes to the .cc file when you're forward declaring the
classes.

[lpromero, 2016-05-26 22:00:56]

ios/ lgtm

[gayane -on leave until 09-2017, 2016-06-01 18:58:39]

addressed @asvitkine's comment.

https://codereview.chromium.org/2014463003/diff/120001/components/metrics/met...
File components/metrics/metrics_reporting_default_state.h (right):

https://codereview.chromium.org/2014463003/diff/120001/components/metrics/met...
components/metrics/metrics_reporting_default_state.h:10: #include
"components/prefs/pref_service.h"
On 2016/05/26 21:08:58, Alexei Svitkine (slow) wrote:
> Nit: Move these #includes to the .cc file when you're forward declaring the
> classes.

Done.

[sky, 2016-06-01 19:51:22]

LGTM

[gayane -on leave until 09-2017, 2016-06-01 22:09:31]

The CQ bit was checked by gayane@chromium.org

[gayane -on leave until 09-2017, 2016-06-01 22:09:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2014463003/#ps140001
(title: " ")

[commit-bot: I haz the power, 2016-06-01 22:10:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014463003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014463003/140001

[commit-bot: I haz the power, 2016-06-02 01:53:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 01:53:36]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Alexei Svitkine (slow), 2016-06-06 18:46:24]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2016-06-06 18:47:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014463003/140001

[commit-bot: I haz the power, 2016-06-06 20:39:29]

Description was changed from

==========
Modifications for recording whether UMA/Crash default state for iOS.

BUG=612828
==========

to

==========
Modifications for recording whether UMA/Crash default state for iOS.

BUG=612828
==========

[commit-bot: I haz the power, 2016-06-06 20:39:30]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2016-06-06 20:42:50]

Description was changed from

==========
Modifications for recording whether UMA/Crash default state for iOS.

BUG=612828
==========

to

==========
Modifications for recording whether UMA/Crash default state for iOS.

BUG=612828

Committed: https://crrev.com/06e66ef365cf2cd743640a8c110309de533c0d48
Cr-Commit-Position: refs/heads/master@{#398116}
==========

[commit-bot: I haz the power, 2016-06-06 20:42:51]

Patchset 4 (id:??) landed as
https://crrev.com/06e66ef365cf2cd743640a8c110309de533c0d48
Cr-Commit-Position: refs/heads/master@{#398116}