Replace GetHostSize with a cross-platform implementation.

Replace GetHostSize with a cross-platform implementation.

This is in preparation for Telemetry for Android devices with a Mac host.

BUG=355646
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259265

[craigdh, 2014-03-24 19:19:54]

not lgtm

https://codereview.chromium.org/201443017/diff/1/build/android/pylib/android_...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/201443017/diff/1/build/android/pylib/android_...
build/android/pylib/android_commands.py:1039: diff_size =
sum(os.stat(f[0]).st_size for f in changed_files)
This doesn't work for directories.

[tonyg, 2014-03-24 23:10:22]

Good catch, please check out this implementation.

[craigdh, 2014-03-24 23:36:46]

https://codereview.chromium.org/201443017/diff/20001/build/android/pylib/andr...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/201443017/diff/20001/build/android/pylib/andr...
build/android/pylib/android_commands.py:1004: def GetHostSize(path):
This is getting really big for an inline function and it seems useful elsewhere,
can we stick this in pylib/utils/ with a unittest? Anything that breaks
PushIfNeeded tends to break things very subtly and painfully on the bots at some
later date.

https://codereview.chromium.org/201443017/diff/20001/build/android/pylib/andr...
build/android/pylib/android_commands.py:1008: running_size +=
sum([GetHostSize(os.path.join(root, f))
You should just be able to call os.path.getsize on files, recursion isn't
necessary.

[tonyg, 2014-03-25 01:58:26]

On 2014/03/24 23:36:46, craigdh wrote:
>
https://codereview.chromium.org/201443017/diff/20001/build/android/pylib/andr...
> File build/android/pylib/android_commands.py (right):
> 
>
https://codereview.chromium.org/201443017/diff/20001/build/android/pylib/andr...
> build/android/pylib/android_commands.py:1004: def GetHostSize(path):
> This is getting really big for an inline function and it seems useful
elsewhere,
> can we stick this in pylib/utils/ with a unittest? Anything that breaks
> PushIfNeeded tends to break things very subtly and painfully on the bots at
some
> later date.

Good call. I've factored it out.

Regarding a unittest, this is the kind of thing that is pretty difficult to test
properly in a cross platform way. Just the naive approach of putting a testdata
directory together wouldn't be very robust because the expectations would assume
something about the OS' directory size (which du includes).

Given that the implementation is smaller again as a result of the below, would
you be willing to review without a test?

> 
>
https://codereview.chromium.org/201443017/diff/20001/build/android/pylib/andr...
> build/android/pylib/android_commands.py:1008: running_size +=
> sum([GetHostSize(os.path.join(root, f))
> You should just be able to call os.path.getsize on files, recursion isn't
> necessary.

You are right. This is cleaner.

[craigdh, 2014-03-25 14:27:31]

lgtm. Thanks!

[tonyg, 2014-03-25 14:51:26]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-03-25 14:51:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tonyg@chromium.org/201443017/40001

[commit-bot: I haz the power, 2014-03-25 18:28:59]

Change committed as 259265