Issue 201443011: Fix markAncestorsWithChildNeedsStyleInvalidation to actually mark only ancestors.

Issue 201443011: Fix markAncestorsWithChildNeedsStyleInvalidation to actually mark only ancestors. (Closed)

Created:
6 years, 9 months ago by chrishtr

Modified:
6 years, 9 months ago

Reviewers:
esprehn, ojan

CC:
blink-reviews, sof, eae+blinkwatch, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, rune+blink, Inactive, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix markAncestorsWithChildNeedsStyleInvalidation to actually mark only ancestors. Make corresponding fix to StyleInvalidator to not break invalidations in which the document element itself needed invalidation. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169788

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments from Ojan. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -6 lines)			Patch
	M	Source/core/css/invalidation/StyleInvalidator.cpp	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
	M	Source/core/dom/Node.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

ojan

lgtm https://codereview.chromium.org/201443011/diff/1/Source/core/css/invalidation/StyleInvalidator.cpp File Source/core/css/invalidation/StyleInvalidator.cpp (right): https://codereview.chromium.org/201443011/diff/1/Source/core/css/invalidation/StyleInvalidator.cpp#newcode23 Source/core/css/invalidation/StyleInvalidator.cpp:23: } Nit: no curlies.

6 years, 9 months ago (2014-03-22 01:14:41 UTC) #3

chrishtr

https://codereview.chromium.org/201443011/diff/1/Source/core/css/invalidation/StyleInvalidator.cpp File Source/core/css/invalidation/StyleInvalidator.cpp (right): https://codereview.chromium.org/201443011/diff/1/Source/core/css/invalidation/StyleInvalidator.cpp#newcode23 Source/core/css/invalidation/StyleInvalidator.cpp:23: } On 2014/03/22 01:14:41, ojan wrote: > Nit: no ...

6 years, 9 months ago (2014-03-22 01:16:12 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/201443011/20001

6 years, 9 months ago (2014-03-22 01:16:39 UTC) #6

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 9 months ago (2014-03-22 01:19:42 UTC) #7

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.blink on blink_presubmit

6 years, 9 months ago (2014-03-22 01:19:43 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/201443011/20001

6 years, 9 months ago (2014-03-22 02:23:09 UTC) #10

Message was sent while issue was closed.

Change committed as 169788

Expand Messages | Collapse Messages