runtime/vm/intermediate_language_arm64.cc - Issue 2014413003: Bump the C stack pointer when building Dart frames to maintain the ARM64 ABI requirements without g…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_arm64.cc

Issue 2014413003: Bump the C stack pointer when building Dart frames to maintain the ARM64 ABI requirements without g… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: assembler test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_arm64.cc

diff --git a/runtime/vm/intermediate_language_arm64.cc b/runtime/vm/intermediate_language_arm64.cc

index 9d167dc6efd1adf54e96e8a103e21b9a5c447938..a2fa2cb40cd41ab75f88cf73c8e8a3c2be0252c2 100644

--- a/runtime/vm/intermediate_language_arm64.cc

+++ b/runtime/vm/intermediate_language_arm64.cc

@@ -2649,7 +2649,9 @@ void CheckStackOverflowInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

compiler->AddSlowPathCode(slow_path);

__ ldr(TMP, Address(THR, Thread::stack_limit_offset()));

- __ CompareRegisters(SP, TMP);

+ // Compare to CSP not SP because CSP is closer to the stack limit. See

+ // Assembler::EnterFrame.

+ __ CompareRegisters(CSP, TMP);

__ b(slow_path->entry_label(), LS);

if (compiler->CanOSRFunction() && in_loop()) {

const Register temp = locs()->temp(0).reg();

« no previous file with comments | « runtime/vm/constants_arm64.h ('k') | runtime/vm/object_arm64_test.cc » ('j') | no next file with comments »