Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: runtime/vm/assembler_arm64.h

Issue 2014413003: Bump the C stack pointer when building Dart frames to maintain the ARM64 ABI requirements without g… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: assembler test Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/assembler_arm64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm64.h
diff --git a/runtime/vm/assembler_arm64.h b/runtime/vm/assembler_arm64.h
index 735e07e7ff2740d5651f1c50bb54bd3bb1a94c6a..8080ab8b6fe9c7e480511ef97615437792847b9f 100644
--- a/runtime/vm/assembler_arm64.h
+++ b/runtime/vm/assembler_arm64.h
@@ -1349,18 +1349,12 @@ class Assembler : public ValueObject {
Register scratch2,
Label* miss);
+ void SetupDartSP();
+ void RestoreCSP();
+
void EnterFrame(intptr_t frame_size);
void LeaveFrame();
- // When entering Dart code from C++, we copy the system stack pointer (CSP)
- // to the Dart stack pointer (SP), and reserve a little space for the stack
- // to grow.
- void SetupDartSP(intptr_t reserved_space) {
- ASSERT(Utils::IsAligned(reserved_space, 16));
- mov(SP, CSP);
- sub(CSP, CSP, Operand(reserved_space));
- }
-
void CheckCodePointer();
void RestoreCodePointer();
« no previous file with comments | « no previous file | runtime/vm/assembler_arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698