Mojo C++ bindings: custom type mapping of map

Mojo C++ bindings: custom type mapping of map

This CL:
- introduces map_traits which is similar to struct_traits;
- adds specialization for mojo::Map and std::map;
- changes the ArraySerializer interface so that it can be re-used by map key/value serialization.

BUG=577686
Committed: https://crrev.com/507ce12625f5a76456ca3f7c844aa65d025aa0b2
Cr-Commit-Position: refs/heads/master@{#396862}

[yzshen1, 2016-05-26 21:55:38]

yzshen@chromium.org changed reviewers:
+ rockot@chromium.org

[yzshen1, 2016-05-26 21:55:39]

Hi, Ken.

Would you please take a look? Thanks!

[yzshen1, 2016-05-26 21:58:30]

https://codereview.chromium.org/2014403002/diff/1/mojo/public/cpp/bindings/li...
File mojo/public/cpp/bindings/lib/map_serialization.h (left):

https://codereview.chromium.org/2014403002/diff/1/mojo/public/cpp/bindings/li...
mojo/public/cpp/bindings/lib/map_serialization.h:100: // short-circuit on
failure here.
(I think we can short-circuit now because of your changes of storing handles in
SerializationContext. Yay!)

[Ken Rockot(use gerrit already), 2016-05-27 16:07:39]

lgtm

https://codereview.chromium.org/2014403002/diff/1/mojo/public/cpp/bindings/li...
File mojo/public/cpp/bindings/lib/array_serialization.h (right):

https://codereview.chromium.org/2014403002/diff/1/mojo/public/cpp/bindings/li...
mojo/public/cpp/bindings/lib/array_serialization.h:71: return
Traits::GetData(input_);
If this can work in the general case (returning null for GetData) we should
document it

https://codereview.chromium.org/2014403002/diff/1/mojo/public/cpp/bindings/li...
mojo/public/cpp/bindings/lib/array_serialization.h:131: for (size_t i = 0; i <
size; ++i)
Nice, this should also be useful for things like base::ListValue

https://codereview.chromium.org/2014403002/diff/1/mojo/public/cpp/bindings/li...
File mojo/public/cpp/bindings/lib/map_serialization.h (left):

https://codereview.chromium.org/2014403002/diff/1/mojo/public/cpp/bindings/li...
mojo/public/cpp/bindings/lib/map_serialization.h:100: // short-circuit on
failure here.
On 2016/05/26 at 21:58:30, yzshen1 wrote:
> (I think we can short-circuit now because of your changes of storing handles
in SerializationContext. Yay!)

Woohoo!

https://codereview.chromium.org/2014403002/diff/1/mojo/public/cpp/bindings/li...
File mojo/public/cpp/bindings/lib/map_serialization.h (right):

https://codereview.chromium.org/2014403002/diff/1/mojo/public/cpp/bindings/li...
mojo/public/cpp/bindings/lib/map_serialization.h:49: const typename Traits::Key&
GetNext() {
Seems a lot of compiles don't like this use of Traits. Maybe we can solve this
by adding an explicit alias in MapKeyReader and MapValueReader as well?

[yzshen1, 2016-05-28 00:23:07]

Thanks!

https://codereview.chromium.org/2014403002/diff/1/mojo/public/cpp/bindings/li...
File mojo/public/cpp/bindings/lib/array_serialization.h (right):

https://codereview.chromium.org/2014403002/diff/1/mojo/public/cpp/bindings/li...
mojo/public/cpp/bindings/lib/array_serialization.h:71: return
Traits::GetData(input_);
On 2016/05/27 16:07:39, Ken Rockot wrote:
> If this can work in the general case (returning null for GetData) we should
> document it

I made the GetData() function of ArrayTraits optional and added documentation.

https://codereview.chromium.org/2014403002/diff/1/mojo/public/cpp/bindings/li...
mojo/public/cpp/bindings/lib/array_serialization.h:131: for (size_t i = 0; i <
size; ++i)
On 2016/05/27 16:07:39, Ken Rockot wrote:
> Nice, this should also be useful for things like base::ListValue

Done.

https://codereview.chromium.org/2014403002/diff/1/mojo/public/cpp/bindings/li...
File mojo/public/cpp/bindings/lib/map_serialization.h (right):

https://codereview.chromium.org/2014403002/diff/1/mojo/public/cpp/bindings/li...
mojo/public/cpp/bindings/lib/map_serialization.h:49: const typename Traits::Key&
GetNext() {
On 2016/05/27 16:07:39, Ken Rockot wrote:
> Seems a lot of compiles don't like this use of Traits. Maybe we can solve this
> by adding an explicit alias in MapKeyReader and MapValueReader as well?

Done.

[yzshen1, 2016-05-28 00:29:14]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2016-05-28 00:29:15]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2014403002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-05-28 00:29:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014403002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014403002/20001

[commit-bot: I haz the power, 2016-05-28 00:50:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-28 00:50:56]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yzshen1, 2016-05-31 16:24:43]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2016-05-31 16:24:44]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2014403002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-05-31 16:25:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014403002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014403002/40001

[commit-bot: I haz the power, 2016-05-31 18:08:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-31 18:10:07]

Description was changed from

==========
Mojo C++ bindings: custom type mapping of map

This CL:
- introduces map_traits which is similar to struct_traits;
- adds specialization for mojo::Map and std::map;
- changes the ArraySerializer interface so that it can be re-used by map
key/value serialization.

BUG=577686
==========

to

==========
Mojo C++ bindings: custom type mapping of map

This CL:
- introduces map_traits which is similar to struct_traits;
- adds specialization for mojo::Map and std::map;
- changes the ArraySerializer interface so that it can be re-used by map
key/value serialization.

BUG=577686

Committed: https://crrev.com/507ce12625f5a76456ca3f7c844aa65d025aa0b2
Cr-Commit-Position: refs/heads/master@{#396862}
==========

[commit-bot: I haz the power, 2016-05-31 18:10:08]

Patchset 3 (id:??) landed as
https://crrev.com/507ce12625f5a76456ca3f7c844aa65d025aa0b2
Cr-Commit-Position: refs/heads/master@{#396862}