Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 2014393002: Revert of [Editing][CSS] Drag from a -webkit-user-select:none element should not start selection (Closed)

Created:
4 years, 6 months ago by luoe
Modified:
4 years, 6 months ago
Reviewers:
tkent, kozy, yosin_UTC9, yoichio
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dcheng, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Editing][CSS] Drag from a -webkit-user-select:none element should not start selection (patchset #1 id:1 of https://codereview.chromium.org/2001993002/ ) Reason for revert: This breaks text selection in the DevTools console when trying to select logged text. https://bugs.chromium.org/p/chromium/issues/detail?id=615227 Original issue's description: > Drag from a -webkit-user-select:none element should not start selection > > BUG=481985 > TEST=LayoutTests/editing/selection/mouse/drag_user_select_none.html > > Committed: https://crrev.com/f6dcdcf4917ba56f5576ef7d5d11d869630d2760 > Cr-Commit-Position: refs/heads/master@{#395856} TBR=tkent@chromium.org,yosin@chromium.org,yoichio@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=481985 Committed: https://crrev.com/4eebd09e213141ed1d7ba0a422d7cf23fbf74fb6 Cr-Commit-Position: refs/heads/master@{#396339}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M third_party/WebKit/LayoutTests/editing/selection/mouse/drag_user_select_none.html View 2 chunks +13 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
luoe
Created Revert of [Editing][CSS] Drag from a -webkit-user-select:none element should not start selection
4 years, 6 months ago (2016-05-26 21:52:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014393002/1
4 years, 6 months ago (2016-05-26 21:53:34 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-05-26 21:53:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014393002/1
4 years, 6 months ago (2016-05-26 22:08:43 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 6 months ago (2016-05-26 22:08:45 UTC) #10
kozy
lgtm
4 years, 6 months ago (2016-05-26 22:09:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014393002/1
4 years, 6 months ago (2016-05-26 22:09:50 UTC) #13
tkent
lgtm
4 years, 6 months ago (2016-05-26 22:53:31 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 01:09:33 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 01:10:58 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4eebd09e213141ed1d7ba0a422d7cf23fbf74fb6
Cr-Commit-Position: refs/heads/master@{#396339}

Powered by Google App Engine
This is Rietveld 408576698