Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1374)

Issue 2014383003: Make AST-based type inference handle <bottom> consistently. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make AST-based type inference handle <bottom> consistently. The non-AST-based type inference engine has the following quirk. With the source code: var x = null; The type of `x` is inferred as `dynamic`, whereas the type of the synthetic initializer function associated with `x` is inferred as `() -> <bottom>`. This CL makes the AST-based type inference engine act in the same way for consistency. In the future we may want to change both engines to consistently infer `dynamic`. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/f251da2dc9f4f8de16ebe1f85079f3f41a610a4e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -11 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 8 chunks +15 lines, -11 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-26 22:04:05 UTC) #2
scheglov
LGTM
4 years, 7 months ago (2016-05-26 22:08:13 UTC) #3
Paul Berry
4 years, 7 months ago (2016-05-26 22:21:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f251da2dc9f4f8de16ebe1f85079f3f41a610a4e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698