relnote: Add a new class QuicBufferedPacketStore which is not in use yet.

relnote: Add a new class QuicBufferedPacketStore which is not in use yet.

This class will be used to defer creation of connection till CHLO
arrives. This class queues early arrived packets for limited number
of connections and upto a limit of packets per connection. And it
deletes the queue if alarm times out before CHLO arrives.

Merge internal change: 122523940 and 123208220.

BUG=

R=rch@chromium.org

Committed: https://crrev.com/dc2b6ce56f3c4646910d38eab054b2603471ca79
Cr-Commit-Position: refs/heads/master@{#396566}

[Ryan Hamilton, 2016-05-26 22:17:37]

Can you remove "patch from issue 2007693002 at patchset 1
(http://crrev.com/2007693002#ps1)" from the CL description?

https://codereview.chromium.org/2014383002/diff/1/net/quic/quic_buffered_pack...
File net/quic/quic_buffered_packet_store.h (right):

https://codereview.chromium.org/2014383002/diff/1/net/quic/quic_buffered_pack...
net/quic/quic_buffered_packet_store.h:93: // this
nit: I'm not sure if this in the internal version but these comments are wrapped
strangely.

[danzh1, 2016-05-27 13:31:51]

Description was changed from

==========
relnote: Add a new class QuicBufferedPacketStore which is not in use yet.

This class will be used to defer creation of connection till CHLO
arrives. This class queues early arrived packets for limited number
of connections and upto a limit of packets per connection. And it
deletes the queue if alarm times out before CHLO arrives.

Merge internal change: 122523940 and 123208220.

BUG=

patch from issue 2007693002 at patchset 1 (http://crrev.com/2007693002#ps1)

R=rch@chromium.org
==========

to

==========
relnote: Add a new class QuicBufferedPacketStore which is not in use yet.

This class will be used to defer creation of connection till CHLO
arrives. This class queues early arrived packets for limited number
of connections and upto a limit of packets per connection. And it
deletes the queue if alarm times out before CHLO arrives.

Merge internal change: 122523940 and 123208220.

BUG=


R=rch@chromium.org
==========

[danzh1, 2016-05-27 13:54:37]

On 2016/05/26 22:17:37, Ryan Hamilton wrote:
> Can you remove "patch from issue 2007693002 at patchset 1
> (http://crrev.com/2007693002#ps1)%22 from the CL description?
> 
>
https://codereview.chromium.org/2014383002/diff/1/net/quic/quic_buffered_pack...
> File net/quic/quic_buffered_packet_store.h (right):
> 
>
https://codereview.chromium.org/2014383002/diff/1/net/quic/quic_buffered_pack...
> net/quic/quic_buffered_packet_store.h:93: // this
> nit: I'm not sure if this in the internal version but these comments are
wrapped
> strangely.

done.

[danzh1, 2016-05-27 13:57:12]

The CQ bit was checked by danzh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-27 13:57:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014383002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014383002/20001

[commit-bot: I haz the power, 2016-05-27 15:12:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 15:12:21]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Ryan Hamilton, 2016-05-27 15:47:51]

LGTM. If the comments were wrapped strangely in the internal version, can you
merge back the formatting change?

Thanks for doing this!

https://codereview.chromium.org/2014383002/diff/20001/net/quic/quic_buffered_...
File net/quic/quic_buffered_packet_store.cc (right):

https://codereview.chromium.org/2014383002/diff/20001/net/quic/quic_buffered_...
net/quic/quic_buffered_packet_store.cc:23: class NET_EXPORT_PRIVATE
ConnectionExpireAlarm : public QuicAlarm::Delegate {
From the windows error message, I think you don't want NET_EXPORT_PRIVATE here
since this class is not visible from other dlls.

[danzh1, 2016-05-27 16:50:54]

The CQ bit was checked by danzh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-27 16:51:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014383002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014383002/40001

[commit-bot: I haz the power, 2016-05-27 17:07:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 17:07:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[danzh1, 2016-05-27 17:18:45]

The CQ bit was checked by danzh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-27 17:19:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014383002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014383002/60001

[commit-bot: I haz the power, 2016-05-27 18:19:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 18:19:29]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[danzh1, 2016-05-27 19:04:02]

The CQ bit was checked by danzh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-27 19:04:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014383002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014383002/80001

[danzh1, 2016-05-27 20:44:37]

On 2016/05/27 15:47:51, Ryan Hamilton wrote:
> LGTM. If the comments were wrapped strangely in the internal version, can you
> merge back the formatting change?

Internal format is fine.

> Thanks for doing this!
> 
>
https://codereview.chromium.org/2014383002/diff/20001/net/quic/quic_buffered_...
> File net/quic/quic_buffered_packet_store.cc (right):
> 
>
https://codereview.chromium.org/2014383002/diff/20001/net/quic/quic_buffered_...
> net/quic/quic_buffered_packet_store.cc:23: class NET_EXPORT_PRIVATE
> ConnectionExpireAlarm : public QuicAlarm::Delegate {
> From the windows error message, I think you don't want NET_EXPORT_PRIVATE here
> since this class is not visible from other dlls.

[commit-bot: I haz the power, 2016-05-27 21:09:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-27 21:09:20]

Dry run: This issue passed the CQ dry run.

[danzh1, 2016-05-27 21:21:07]

The CQ bit was checked by danzh@chromium.org

[danzh1, 2016-05-27 21:21:07]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2014383002/#ps80001
(title: "add NEXT_EXPOERT_PRIVATE to BufferedPakcet")

[commit-bot: I haz the power, 2016-05-27 21:21:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014383002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014383002/80001

[commit-bot: I haz the power, 2016-05-27 21:26:44]

Description was changed from

==========
relnote: Add a new class QuicBufferedPacketStore which is not in use yet.

This class will be used to defer creation of connection till CHLO
arrives. This class queues early arrived packets for limited number
of connections and upto a limit of packets per connection. And it
deletes the queue if alarm times out before CHLO arrives.

Merge internal change: 122523940 and 123208220.

BUG=


R=rch@chromium.org
==========

to

==========
relnote: Add a new class QuicBufferedPacketStore which is not in use yet.

This class will be used to defer creation of connection till CHLO
arrives. This class queues early arrived packets for limited number
of connections and upto a limit of packets per connection. And it
deletes the queue if alarm times out before CHLO arrives.

Merge internal change: 122523940 and 123208220.

BUG=


R=rch@chromium.org
==========

[commit-bot: I haz the power, 2016-05-27 21:26:45]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-27 21:29:33]

Description was changed from

==========
relnote: Add a new class QuicBufferedPacketStore which is not in use yet.

This class will be used to defer creation of connection till CHLO
arrives. This class queues early arrived packets for limited number
of connections and upto a limit of packets per connection. And it
deletes the queue if alarm times out before CHLO arrives.

Merge internal change: 122523940 and 123208220.

BUG=


R=rch@chromium.org
==========

to

==========
relnote: Add a new class QuicBufferedPacketStore which is not in use yet.

This class will be used to defer creation of connection till CHLO
arrives. This class queues early arrived packets for limited number
of connections and upto a limit of packets per connection. And it
deletes the queue if alarm times out before CHLO arrives.

Merge internal change: 122523940 and 123208220.

BUG=

R=rch@chromium.org

Committed: https://crrev.com/dc2b6ce56f3c4646910d38eab054b2603471ca79
Cr-Commit-Position: refs/heads/master@{#396566}
==========

[commit-bot: I haz the power, 2016-05-27 21:29:34]

Patchset 5 (id:??) landed as
https://crrev.com/dc2b6ce56f3c4646910d38eab054b2603471ca79
Cr-Commit-Position: refs/heads/master@{#396566}