Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Issue 2014373003: [wasm] Add more tests for interpreter breakpoints. (Closed)

Created:
4 years, 6 months ago by titzer
Modified:
4 years, 6 months ago
Reviewers:
ahaas, binji
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Add more tests for interpreter breakpoints. R=binji@chromium.org,ahaas@chromium.org BUG= Committed: https://crrev.com/96774fa541b8c24f1d2c2eb9a293f61ab4d71ba6 Cr-Commit-Position: refs/heads/master@{#36577}

Patch Set 1 #

Patch Set 2 : Signed/unsigned #

Total comments: 1

Patch Set 3 : Remove redundant local #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -24 lines) Patch
M src/wasm/wasm-interpreter.h View 3 chunks +5 lines, -2 lines 0 comments Download
M src/wasm/wasm-interpreter.cc View 1 9 chunks +31 lines, -14 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-interpreter.cc View 1 2 1 chunk +144 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
titzer
4 years, 6 months ago (2016-05-27 12:54:29 UTC) #1
ahaas
lgtm https://codereview.chromium.org/2014373003/diff/20001/test/cctest/wasm/test-run-wasm-interpreter.cc File test/cctest/wasm/test-run-wasm-interpreter.cc (right): https://codereview.chromium.org/2014373003/diff/20001/test/cctest/wasm/test-run-wasm-interpreter.cc#newcode146 test/cctest/wasm/test-run-wasm-interpreter.cc:146: SmartArrayPointer<int> offsets(raw); Could you not just say SmartArrayPointer<int> ...
4 years, 6 months ago (2016-05-30 08:19:31 UTC) #2
titzer
On 2016/05/30 08:19:31, ahaas wrote: > lgtm > > https://codereview.chromium.org/2014373003/diff/20001/test/cctest/wasm/test-run-wasm-interpreter.cc > File test/cctest/wasm/test-run-wasm-interpreter.cc (right): > ...
4 years, 6 months ago (2016-05-30 08:29:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014373003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014373003/40001
4 years, 6 months ago (2016-05-30 09:50:03 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-05-30 10:02:39 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-05-30 10:03:45 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/96774fa541b8c24f1d2c2eb9a293f61ab4d71ba6
Cr-Commit-Position: refs/heads/master@{#36577}

Powered by Google App Engine
This is Rietveld 408576698