Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(724)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2014363002: Make additional FXJSE_CLASS_DESCRIPTORS constant (Closed)

Created:
4 years, 7 months ago by Tom Sepez
Modified:
4 years, 7 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make additional FXJSE_CLASS_DESCRIPTORS constant Also, no need to track these in the contexts since they are global. Committed: https://pdfium.googlesource.com/pdfium/+/5c4dd35a1ea2ba25839c8dabb4388a5dfc811165

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -51 lines) Patch
M xfa/fxfa/fm2js/xfa_fm2jscontext.h View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.h View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.cpp View 5 chunks +50 lines, -44 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
Dan, follow-up cl.
4 years, 7 months ago (2016-05-26 20:50:40 UTC) #2
dsinclair
lgtm
4 years, 7 months ago (2016-05-26 20:55:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014363002/1
4 years, 7 months ago (2016-05-26 20:55:42 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-26 20:58:02 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/5c4dd35a1ea2ba25839c8dabb4388a5dfc81...

Powered by Google App Engine
This is Rietveld 408576698