Make Mac and Linux first run dialogs use metrics APIs.

Make Mac and Linux first run dialogs use metrics APIs.

This makes the two implementations use the APIs from
chrome/browser/metrics/metrics_reporting_state.h to check
if the pref is managed and to set it.

This also fixes a bug where the metrics service wouldn't
be started on first run because neither of the two existing
implementations would call Start() on it, which is fixed
by using InitiateMetricsReportingChange() which does this.

BUG=615203
Committed: https://crrev.com/aebe925d51198f3ad6c964a8a9afa96ecabdafe2
Cr-Commit-Position: refs/heads/master@{#396537}

[Alexei Svitkine (slow), 2016-05-26 21:01:55]

Description was changed from

==========
Make Mac and Linux first run dialogs use metrics APIs.

This makes the two implementations use the APIs from
chrome/browser/metrics/metrics_reporting_state.h to check
if the pref is managed and to set it.

This also fixes a bug where the metrics service wouldn't
be started on first run because neither of the two existing
implementations would call Start() on it, which is fixed
by using InitiateMetricsReportingChange() which does this.

BUG=...
==========

to

==========
Make Mac and Linux first run dialogs use metrics APIs.

This makes the two implementations use the APIs from
chrome/browser/metrics/metrics_reporting_state.h to check
if the pref is managed and to set it.

This also fixes a bug where the metrics service wouldn't
be started on first run because neither of the two existing
implementations would call Start() on it, which is fixed
by using InitiateMetricsReportingChange() which does this.

BUG=615203
==========

[Alexei Svitkine (slow), 2016-05-26 21:02:04]

Patchset #1 (id:1) has been deleted

[Alexei Svitkine (slow), 2016-05-26 21:04:36]

Patchset #1 (id:20001) has been deleted

[Alexei Svitkine (slow), 2016-05-26 21:06:22]

asvitkine@chromium.org changed reviewers:
+ gayane@chromium.org

[Alexei Svitkine (slow), 2016-05-26 21:06:22]

Gayane, please do an initial review before I send to owners.

[Alexei Svitkine (slow), 2016-05-26 22:09:04]

Patchset #1 (id:40001) has been deleted

[gayane -on leave until 09-2017, 2016-05-27 15:15:00]

Looks good.

[gayane -on leave until 09-2017, 2016-05-27 15:21:55]

lgtm

[gayane -on leave until 09-2017, 2016-05-27 15:21:57]

lgtm

[Alexei Svitkine (slow), 2016-05-27 15:22:12]

asvitkine@chromium.org changed reviewers:
+ sky@chromium.org

[Alexei Svitkine (slow), 2016-05-27 15:22:13]

Thanks!

+sky for OWNERS

[sky, 2016-05-27 16:13:05]

LGTM with no null check

https://codereview.chromium.org/2014353002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/first_run_dialog.cc (right):

https://codereview.chromium.org/2014353002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/first_run_dialog.cc:119: bool consent_given =
(report_crashes_ && report_crashes_->checked());
report_crashes_ is never null. Why the null check?

[Alexei Svitkine (slow), 2016-05-27 18:57:19]

https://codereview.chromium.org/2014353002/diff/60001/chrome/browser/ui/views...
File chrome/browser/ui/views/first_run_dialog.cc (right):

https://codereview.chromium.org/2014353002/diff/60001/chrome/browser/ui/views...
chrome/browser/ui/views/first_run_dialog.cc:119: bool consent_given =
(report_crashes_ && report_crashes_->checked());
On 2016/05/27 16:13:05, sky wrote:
> report_crashes_ is never null. Why the null check?

Done. It was in the original code but I agree it's not needed. Also removed the
null check from the make_default_ if below.

[Alexei Svitkine (slow), 2016-05-27 18:58:31]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-05-27 18:58:31]

The patchset sent to the CQ was uploaded after l-g-t-m from gayane@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2014353002/#ps80001
(title: "Address comment.")

[commit-bot: I haz the power, 2016-05-27 18:58:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2014353002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2014353002/80001

[commit-bot: I haz the power, 2016-05-27 19:48:14]

Description was changed from

==========
Make Mac and Linux first run dialogs use metrics APIs.

This makes the two implementations use the APIs from
chrome/browser/metrics/metrics_reporting_state.h to check
if the pref is managed and to set it.

This also fixes a bug where the metrics service wouldn't
be started on first run because neither of the two existing
implementations would call Start() on it, which is fixed
by using InitiateMetricsReportingChange() which does this.

BUG=615203
==========

to

==========
Make Mac and Linux first run dialogs use metrics APIs.

This makes the two implementations use the APIs from
chrome/browser/metrics/metrics_reporting_state.h to check
if the pref is managed and to set it.

This also fixes a bug where the metrics service wouldn't
be started on first run because neither of the two existing
implementations would call Start() on it, which is fixed
by using InitiateMetricsReportingChange() which does this.

BUG=615203
==========

[commit-bot: I haz the power, 2016-05-27 19:48:15]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-05-27 19:49:50]

Description was changed from

==========
Make Mac and Linux first run dialogs use metrics APIs.

This makes the two implementations use the APIs from
chrome/browser/metrics/metrics_reporting_state.h to check
if the pref is managed and to set it.

This also fixes a bug where the metrics service wouldn't
be started on first run because neither of the two existing
implementations would call Start() on it, which is fixed
by using InitiateMetricsReportingChange() which does this.

BUG=615203
==========

to

==========
Make Mac and Linux first run dialogs use metrics APIs.

This makes the two implementations use the APIs from
chrome/browser/metrics/metrics_reporting_state.h to check
if the pref is managed and to set it.

This also fixes a bug where the metrics service wouldn't
be started on first run because neither of the two existing
implementations would call Start() on it, which is fixed
by using InitiateMetricsReportingChange() which does this.

BUG=615203

Committed: https://crrev.com/aebe925d51198f3ad6c964a8a9afa96ecabdafe2
Cr-Commit-Position: refs/heads/master@{#396537}
==========

[commit-bot: I haz the power, 2016-05-27 19:49:52]

Patchset 2 (id:??) landed as
https://crrev.com/aebe925d51198f3ad6c964a8a9afa96ecabdafe2
Cr-Commit-Position: refs/heads/master@{#396537}