Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2014343004: [runtime] Allow generic allocation of sloppy arguments. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Allow generic allocation of sloppy arguments. This allows sloppy arguments objects to be allocated by the generic Heap::AllocateJSObjectFromMap allocation function. An empty elements backing store for such objects is provided. This is needed in order to materialize such objects without access to a specific native context. R=bmeurer@chromium.org TEST=mjsunit/regress/regress-crbug-613919 BUG=chromium:613919 Committed: https://crrev.com/addfd00a20f4b9ddabf7e71d51aa524431ec0090 Cr-Commit-Position: refs/heads/master@{#36547}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -14 lines) Patch
M src/deoptimizer.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M src/heap/heap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +9 lines, -1 line 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 2 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 6 months ago (2016-05-27 12:11:22 UTC) #1
Benedikt Meurer
Nice. LGTM.
4 years, 6 months ago (2016-05-27 12:12:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014343004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014343004/1
4 years, 6 months ago (2016-05-27 12:18:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 12:37:29 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 12:39:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/addfd00a20f4b9ddabf7e71d51aa524431ec0090
Cr-Commit-Position: refs/heads/master@{#36547}

Powered by Google App Engine
This is Rietveld 408576698