Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2014333002: [Android] Fix unknown handling in gtest_test_instance. (Closed)

Created:
4 years, 7 months ago by jbudorick
Modified:
4 years, 7 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix unknown handling in gtest_test_instance. BUG=615086, 615291 TBR=dewittj@chromium.org Committed: https://crrev.com/f7461118211ccac06090eb8b70d25c52aa314a1b Cr-Commit-Position: refs/heads/master@{#396378}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : disable failing tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -54 lines) Patch
M build/android/pylib/gtest/gtest_test_instance.py View 3 chunks +60 lines, -50 lines 0 comments Download
M build/android/pylib/gtest/gtest_test_instance_test.py View 2 chunks +72 lines, -0 lines 0 comments Download
M build/android/pylib/local/device/local_device_gtest_run.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/remote/device/remote_device_gtest_run.py View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/mhtml_generation_browsertest.cc View 1 2 2 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
jbudorick
4 years, 7 months ago (2016-05-26 19:55:20 UTC) #2
rnephew (Reviews Here)
On 2016/05/26 19:55:20, jbudorick wrote: lgtm
4 years, 7 months ago (2016-05-26 23:18:56 UTC) #3
jbudorick
TBR dewittj: disabling two tests you added in https://codereview.chromium.org/1977303003
4 years, 7 months ago (2016-05-27 02:34:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014333002/40001
4 years, 7 months ago (2016-05-27 02:35:44 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-27 04:31:00 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-27 04:33:56 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f7461118211ccac06090eb8b70d25c52aa314a1b
Cr-Commit-Position: refs/heads/master@{#396378}

Powered by Google App Engine
This is Rietveld 408576698