Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: extensions/renderer/script_injection.cc

Issue 2014323002: Use std::unique_ptr<base::Value> in V8ValueConverter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android fixes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/activity_log_converter_strategy.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/script_injection.cc
diff --git a/extensions/renderer/script_injection.cc b/extensions/renderer/script_injection.cc
index 8933f664d20c16b01cd12ec0d8cc9bace1a7593a..f867800b03f3569e402eda5954263fcaa432cc1c 100644
--- a/extensions/renderer/script_injection.cc
+++ b/extensions/renderer/script_injection.cc
@@ -292,7 +292,7 @@ void ScriptInjection::OnJsInjectionCompleted(
// when encountered.
v8::Local<v8::Context> context =
render_frame_->GetWebFrame()->mainWorldScriptContext();
- execution_result_.reset(v8_converter->FromV8Value(results[0], context));
+ execution_result_ = v8_converter->FromV8Value(results[0], context);
}
if (!execution_result_.get())
execution_result_ = base::Value::CreateNullValue();
« no previous file with comments | « extensions/renderer/activity_log_converter_strategy.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698