Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: content/renderer/web_ui_extension.cc

Issue 2014323002: Use std::unique_ptr<base::Value> in V8ValueConverter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android fixes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/web_ui_extension.cc
diff --git a/content/renderer/web_ui_extension.cc b/content/renderer/web_ui_extension.cc
index 0751e6ee68b4c3dde2fc569a5c1a701509831e1c..a793b4e215b1121be9f10b0a1623ca783c1214e7 100644
--- a/content/renderer/web_ui_extension.cc
+++ b/content/renderer/web_ui_extension.cc
@@ -5,6 +5,7 @@
#include "content/renderer/web_ui_extension.h"
#include <memory>
+#include <utility>
#include "base/values.h"
#include "content/common/view_messages.h"
@@ -108,13 +109,9 @@ void WebUIExtension::Send(gin::Arguments* args) {
}
std::unique_ptr<V8ValueConverter> converter(V8ValueConverter::create());
-
- base::Value* value =
- converter->FromV8Value(obj, frame->mainWorldScriptContext());
- base::ListValue* list = NULL;
- value->GetAsList(&list);
- DCHECK(list);
- content.reset(list);
+ content = base::ListValue::From(
+ converter->FromV8Value(obj, frame->mainWorldScriptContext()));
+ DCHECK(content);
}
// Send the message up to the browser.
« no previous file with comments | « content/renderer/java/gin_java_bridge_value_converter.cc ('k') | extensions/renderer/activity_log_converter_strategy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698