chrome/browser/extensions/extension_creator.cc - Issue 20142007: Catch the sign zip error earlier to prevent invalid private key crash Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_creator.cc

Issue 20142007: Catch the sign zip error earlier to prevent invalid private key crash Chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add test case for packing extension with invalid private key. Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Index: chrome/browser/extensions/extension_creator.cc

diff --git a/chrome/browser/extensions/extension_creator.cc b/chrome/browser/extensions/extension_creator.cc

index e344338297db7fc9c296e8a330f87a982b85ce45..cbcf078a5df5421d730bb363724d97e55edc89e6 100644

--- a/chrome/browser/extensions/extension_creator.cc

+++ b/chrome/browser/extensions/extension_creator.cc

@@ -228,7 +228,12 @@ bool ExtensionCreator::SignZip(const base::FilePath& zip_path,

}

zip_handle.Close();

- signature_creator->Final(signature);

+ if (!signature_creator->Final(signature)) {

+ error_message_ =

+ l10n_util::GetStringUTF8(IDS_EXTENSION_ERROR_WHILE_SIGNING);

+ return false;

+ }

return true;

}

« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service_unittest.cc » ('j') | no next file with comments »