Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2014153002: Implement the use counter for :defined pseudo-class selector (Closed)

Created:
4 years, 7 months ago by kojii
Modified:
4 years, 7 months ago
CC:
darktears, apavlov+blink_chromium.org, asvitkine+watch_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement the use counter for :defined pseudo-class selector This patch implements the use counter for :defined pseudo-class selector[1]. This selector was implemented in crrev.com/396139. [1] https://html.spec.whatwg.org/multipage/scripting.html#selector-defined BUG=594918 Committed: https://crrev.com/f5750fbf520618038fe934a25db4e8bfde0f0ca5 Cr-Commit-Position: refs/heads/master@{#396398}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
kojii
holte@, PTAL for tools/metrics dominicc@, PTAL for core
4 years, 7 months ago (2016-05-26 08:02:35 UTC) #3
rune
core/ lgtm
4 years, 7 months ago (2016-05-26 09:03:09 UTC) #5
kojii
Thank you rune@ for the prompt review! holte@, appreciate your review on tools/metrics
4 years, 7 months ago (2016-05-26 09:07:43 UTC) #6
Steven Holte
lgtm
4 years, 7 months ago (2016-05-26 19:47:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014153002/1
4 years, 7 months ago (2016-05-27 01:22:41 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/190904)
4 years, 7 months ago (2016-05-27 01:29:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2014153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2014153002/20001
4 years, 7 months ago (2016-05-27 04:02:20 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-27 05:28:32 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-27 05:30:57 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f5750fbf520618038fe934a25db4e8bfde0f0ca5
Cr-Commit-Position: refs/heads/master@{#396398}

Powered by Google App Engine
This is Rietveld 408576698