Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc

Issue 2014103002: Remove deprecated ListValue::Append(Value*) overload on Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ADL fail Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/referrer.cc ('k') | chrome/browser/signin/signin_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
diff --git a/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc b/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
index 4500c966af00b8642515d6d64f5f11470100e035..dced8e429a2174b9761ad818c78353c48921e1fd 100644
--- a/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
+++ b/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc
@@ -6,9 +6,11 @@
#include <map>
#include <string>
+#include <utility>
#include <vector>
#include "base/command_line.h"
+#include "base/memory/ptr_util.h"
#include "base/run_loop.h"
#include "build/build_config.h"
#include "components/os_crypt/os_crypt_mocker.h"
@@ -540,11 +542,11 @@ TEST_F(MutableProfileOAuth2TokenServiceDelegateTest, GaiaIdMigration) {
ListPrefUpdate update(&pref_service_,
AccountTrackerService::kAccountInfoPref);
update->Clear();
- base::DictionaryValue* dict = new base::DictionaryValue();
- update->Append(dict);
+ auto dict = base::MakeUnique<base::DictionaryValue>();
dict->SetString("account_id", base::UTF8ToUTF16(email));
dict->SetString("email", base::UTF8ToUTF16(email));
dict->SetString("gaia", base::UTF8ToUTF16(gaia_id));
+ update->Append(std::move(dict));
account_tracker_service_.Shutdown();
account_tracker_service_.Initialize(client_.get());
@@ -599,16 +601,16 @@ TEST_F(MutableProfileOAuth2TokenServiceDelegateTest,
ListPrefUpdate update(&pref_service_,
AccountTrackerService::kAccountInfoPref);
update->Clear();
- base::DictionaryValue* dict = new base::DictionaryValue();
- update->Append(dict);
+ auto dict = base::MakeUnique<base::DictionaryValue>();
dict->SetString("account_id", base::UTF8ToUTF16(email1));
dict->SetString("email", base::UTF8ToUTF16(email1));
dict->SetString("gaia", base::UTF8ToUTF16(gaia_id1));
- dict = new base::DictionaryValue();
- update->Append(dict);
+ update->Append(std::move(dict));
+ dict = base::MakeUnique<base::DictionaryValue>();
dict->SetString("account_id", base::UTF8ToUTF16(email2));
dict->SetString("email", base::UTF8ToUTF16(email2));
dict->SetString("gaia", base::UTF8ToUTF16(gaia_id2));
+ update->Append(std::move(dict));
account_tracker_service_.Shutdown();
account_tracker_service_.Initialize(client_.get());
« no previous file with comments | « chrome/browser/net/referrer.cc ('k') | chrome/browser/signin/signin_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698