chrome/browser/custom_handlers/protocol_handler_registry.cc - Issue 2014103002: Remove deprecated ListValue::Append(Value*) overload on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/custom_handlers/protocol_handler_registry.cc

Issue 2014103002: Remove deprecated ListValue::Append(Value*) overload on Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ADL fail Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/bookmarks/managed_bookmark_service_unittest.cc ('k') | chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/custom_handlers/protocol_handler_registry.cc

diff --git a/chrome/browser/custom_handlers/protocol_handler_registry.cc b/chrome/browser/custom_handlers/protocol_handler_registry.cc

index ab59762240b442f8dbd0b8e096adce05faa914bf..596682630c3681d2be89ec853dc14be19117e1ab 100644

--- a/chrome/browser/custom_handlers/protocol_handler_registry.cc

+++ b/chrome/browser/custom_handlers/protocol_handler_registry.cc

@@ -6,6 +6,7 @@

#include <stddef.h>

+#include <memory>

#include <utility>

#include "base/bind.h"

@@ -760,11 +761,11 @@ base::Value* ProtocolHandlerRegistry::EncodeRegisteredHandlers() {

++i) {

for (ProtocolHandlerList::iterator j = i->second.begin();

j != i->second.end(); ++j) {

- base::DictionaryValue* encoded = j->Encode();

+ std::unique_ptr<base::DictionaryValue> encoded = j->Encode();

if (IsDefault(*j)) {

encoded->Set("default", new base::FundamentalValue(true));

}

- protocol_handlers->Append(encoded);

+ protocol_handlers->Append(std::move(encoded));

}

return protocol_handlers;