chrome/common/custom_handlers/protocol_handler.h - Issue 2014103002: Remove deprecated ListValue::Append(Value*) overload on Linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/custom_handlers/protocol_handler.h

Issue 2014103002: Remove deprecated ListValue::Append(Value*) overload on Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Raw pointer =( Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/devtools/devtools_targets_ui.cc ('K') | « chrome/browser/sync/test/integration/preferences_helper.cc ('k') | chrome/common/custom_handlers/protocol_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/custom_handlers/protocol_handler.h

diff --git a/chrome/common/custom_handlers/protocol_handler.h b/chrome/common/custom_handlers/protocol_handler.h

index 745a3f52d5a67caaff9d1b19b11f83cc9b45f7c1..69c195c7c5628e6380a88849f2ea27bfe038954f 100644

--- a/chrome/common/custom_handlers/protocol_handler.h

+++ b/chrome/common/custom_handlers/protocol_handler.h

@@ -5,6 +5,7 @@

#ifndef CHROME_COMMON_CUSTOM_HANDLERS_PROTOCOL_HANDLER_H_

#define CHROME_COMMON_CUSTOM_HANDLERS_PROTOCOL_HANDLER_H_

+#include <memory>

#include <string>

#include "base/values.h"

@@ -41,9 +42,8 @@ class ProtocolHandler {

// ignored.

bool IsEquivalent(const ProtocolHandler& other) const;

- // Encodes this protocol handler as a DictionaryValue. The caller is

- // responsible for deleting the returned value.

- base::DictionaryValue* Encode() const;

+ // Encodes this protocol handler as a DictionaryValue.

+ std::unique_ptr<base::DictionaryValue> Encode() const;

const std::string& protocol() const { return protocol_; }

const GURL& url() const { return url_;}